[PATCH] Show combined costs in gate conversion tooltip.

[wraitii]

The gate conversion tooltip only takes a single gate into account, even when the user has selected multiple long walls segment. It should take every wall segment into account and update the tooltip. It should also make sure the red overlay (showing a lack of resources) is correctly updated for multiple gates, see #1571.

[sanderd17]

Two things I only leared myself recently:

• You should make the svn diff from the root svn directory. That way, it will be easy to apply, and it will display nicely in trac
• You should clean your diff, all those lines where you changed an emptyline with tabs to one without tabs shouldn't happen. Just edit the diff in a text editor, and use those paragraphs.

[Jake Ware]

Replying to sanderd17: Thanks, did it seem alright otherwise?

[sanderd17]

The code looks alright on first sight. But I haven't got around testing it. The code looks clean though.

Also, note the indentation. That's done with tabs in 0 A.D. (​http://trac.wildfiregames.com/wiki/Coding_Conventions)

[Jake Ware]

Yes, I read that. The non-tab indentation was just a couple typos. Re-uploading the cleaned patch now.

[Jake Ware]

Cleaned edit

[sanderd17]

I tried it, and it seems to work as it should. Thanks for the patch.

[Jake Ware]

My pleasure.

[leper]

Wouldn't the patch get a lot shorter by using JavaScripts Array.reduce()?

[Jake Ware]

Leper: I'll look into it. I honestly wasn't expecting to be using javascript a whole lot when I first found the project, and I am certainly not a JS expert, so I didn't know that that function existed.

[leper]

In 13511:

Show combined costs in the gate conversion tooltip. Based on patch by Jgwman. Fixes #1591.

[leper]

Thanks for the patch. I replaced the counting code with Array.reduce and fixed a small bug related to the time display.

[Jake Ware]

Cool, sorry, I haven't had much time lately.