[PATCH] Insufficient population capacity tooltip

[zoot]

Description of the feature:

When you've added a training order to the production queue, and there aren't sufficient population capacity for the order to commence, hovering over the production icon in the queue will show the amount of capacity missing (so you can determine at a glance how many houses you need to build etc.)

(Feel free to come up with a better wording than "Insufficient population capacity".)

Also, the icon will blink orange instead of just being green.

See this thread for images and animation.

[zoot]

Updated patch per Deiz's suggestions:

• Move population counter blinking into onSimulationUpdate().
• Use "colour: r g b a" sprite instead of defining a new one in sprites.xml.
• Fix as many indentation errors as possible.

[leper]

Nice to see you using trac :-). Just for future patches: Please take a look at SubmittingPatches.

[Deiz]

There's one small issue with making it all run on simulation update: Single-player simulation turns are 200ms, so the indicators will be orange for either 400ms or 600ms. Shouldn't matter much in multiplayer since its turn rate is 500ms

In any case, the production queue blinking requires knowledge of the particular selected entity, and I think it'd be far uglier to cram that code into session.js's onTick than it is to deal with some minor visual inconsistencies.

[Kieran P]

Moving to next release because changes are required before this can be completed.

[zoot]

I've cleaned this up a bit:

​https://github.com/zootzoot/0ad/compare/insufficient-pop-capacity-tooltip (​diff)

The tooltip now mirrors the "insufficient resources" tooltip, with icon for the population count, as seen below. Also, I've dropped the 'blinking' feature which wasn't ready for prime-time. I'll add that in separate ticket if I get it to work.

[leper]

Why don't you return 0 on success and the number of needed slots (positive) on failure? That way you can just have item.slots (maybe rename to neededSlots).

[historic_bruno]

It wasn't introduced by this patch, but there's currently a weird redundant test for item.unitTemplate on lines 548 and 552. Also the added slots property should be documented in the comment block around line 40-49.

[zoot]

Replying to leper:

Why don't you return 0 on success and the number of needed slots (positive) on failure? That way you can just have item.slots (maybe rename to neededSlots).

​Done.

Replying to historic_bruno:

It wasn't introduced by this patch, but there's currently a weird redundant test for item.unitTemplate on lines 548 and 552.

​Done.

Also the added slots property should be documented in the comment block around line 40-49.

​Done.

New diff: ​https://github.com/zootzoot/0ad/compare/insufficient-pop-capacity-tooltip.diff

[leper]

In 13198:

Add insufficient population count to production queue tooltip. Patch by zoot. Fixes #1659.

[leper]

Thanks for the patch.