[PATCH] Add "Random" option to map selection dropdown

[O.Davoodi]

Here is a patch. Notice that there is no such an option for scenarios because of their non-fixed player count.

[historic_bruno]

We could also add something like AOK's "Random land map" option, which would select a non-naval map, and "Random" would select from all random maps as in your patch.

[O.Davoodi]

My patch already handles that. It selects a random map from the current "list" meaning that map filters are important.

[historic_bruno]

Ah, that works :)

[historic_bruno]

After applying the patch I get these errors after trying to play Random:

WARNING: JavaScript warning: gui/gamesetup/gamesetup.js line 777 reference to undefined property g_GameAttributes.map.Name

WARNING: JavaScript warning: Script value conversion check failed: JSVAL_IS_STRING(v) || JSVAL_IS_NUMBER(v) (got type undefined)

ERROR: File 'maps/random/undefined' does not exist

ERROR: CMapGeneratorWorker::Run: Failed to load RMS 'maps/random/undefined'

The warnings also appear for scenarios.

I would suggest changing "Random" to a different color as we do for random civs, so it stands out more from the rest of the list.

[Deiz]

Warning stems from :777, which is probably supposed to be:

if (g_GameAttributes.map == "random")

I assume so because g_GameAttributes.map is a string, not an object, and the random map "filename" to be swapped out is "random", not "Random".

[O.Davoodi]

Oh I'm really sorry. I didn't copy the newer files into my checkout directory before creating the patches.

[O.Davoodi]

fixed patch

[Deiz]

Version I've uploaded trims some trailing whitespace. I also colourized the map name for the host; unsure if it should also be done at the map data level, as that would make both the client display and the label above the map description orange.

[O.Davoodi]

Well, what are we waiting for now? Let's commit this. :)

[Erik Johansson]

You've got commit powers you know ;)

[O.Davoodi]

I wanted to make sure Deiz doesn't want to change anything. :)

[O.Davoodi]

In 12684:

Adding the "Random" option in map selection. Fixes #1668

[fabio]

Nice! Can also be added to Scenario maps?

EDIT: Random is white here, not orange.

[O.Davoodi]

In 12685:

Making the "random" option in the map selection dropdown orange. Refs #1668