Opened 11 years ago

Closed 11 years ago

Last modified 8 years ago

#1854 closed enhancement (fixed)

[PATCH] Simplify construction of the transformation matrix in GetInterpolatedTransform

Reported by: sbte Owned by: wraitii
Priority: Should Have Milestone: Alpha 13
Component: UI & Simulation Keywords: patch
Cc: Patch:


A patch to simplify (and speed up) some computations

Attachments (2)

0001-Simplify-the-construction-of-the-transformation-matr.patch (1.3 KB ) - added by sbte 11 years ago.
Transformation matrix patch
Capture d’écran 2013-03-07 à 08.26.24.png (211.0 KB ) - added by wraitii 11 years ago.

Download all attachments as: .zip

Change History (11)

by sbte, 11 years ago

Transformation matrix patch

comment:1 by wraitii, 11 years ago

Not sure what goes wrong, but I'm getting this bug. The unit doesn't appear to move at all if I click around it, though it does appear to move over long distances for some reason.

Not sure about the math itself, rotation matrices is not something I'll learn.

(Edit: actually... I get that error even without the patch. Thoses changes seem allright, but you might have broken something with oyur previous patch for me). (Edit nb 2: cleaned/recompiled: seems to work now).

Edit 3: definitely not fixed all the time. Units are slightly translated, and siege units don't register rotation sometimes. But that seems related to your precedent changes.

Last edited 11 years ago by wraitii (previous) (diff)

comment:2 by B. Guns, 11 years ago


Maybe you could also have a look at this :) #1707

Last edited 11 years ago by historic_bruno (previous) (diff)

comment:3 by sbte, 11 years ago

@plumo, I will

@wraitii, I am definitely curious about that bug, because I cannot seem to reproduce it. If I can find a way to reproduce it I can do a git bisect to find the commit that broke it.

comment:4 by wraitii, 11 years ago

sbte: some tidbit of info: it seems to only happen when I run the simulation speed at about 10/15 times the normal speed. I guess when the framerate starts being really low, there are some "jumps" now and then.

Try to start a game with an AI (added lag) and run "Engine.SetSimRate(20)". You should see units placed oddly around farms/resources.

Beyond that, patch seems to work fine.

Last edited 11 years ago by wraitii (previous) (diff)

comment:5 by sbte, 11 years ago

Component: Core engineUI & Simulation
Milestone: BacklogAlpha 13

comment:6 by Kieran P, 11 years ago

I see the same thing on the latest SVN, so not related to this patch, and same as wraitii, seems to happen when SetSimRate is used.

comment:7 by sbte, 11 years ago

@k776, there's a patch for it in #1858

comment:8 by wraitii, 11 years ago

Owner: set to wraitii
Resolution: fixed
Status: newclosed

In 13252:

Simplify construction of the transformation matrix in GetInterpolatedTransform. Patch by sbte. Fixes #1854

comment:9 by sanderd17, 8 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.