[PATCH] Simplify construction of the transformation matrix in GetInterpolatedTransform

[sbte]

A patch to simplify (and speed up) some computations

[sbte]

Transformation matrix patch

[wraitii]

Not sure what goes wrong, but I'm getting this bug. The unit doesn't appear to move at all if I click around it, though it does appear to move over long distances for some reason.

Not sure about the math itself, rotation matrices is not something I'll learn.

(Edit: actually... I get that error even without the patch. Thoses changes seem allright, but you might have broken something with oyur previous patch for me). (Edit nb 2: cleaned/recompiled: seems to work now).

Edit 3: definitely not fixed all the time. Units are slightly translated, and siege units don't register rotation sometimes. But that seems related to your precedent changes.

[B. Guns]

@sbte

Maybe you could also have a look at this :) #1707

[sbte]

@plumo, I will

@wraitii, I am definitely curious about that bug, because I cannot seem to reproduce it. If I can find a way to reproduce it I can do a git bisect to find the commit that broke it.

[wraitii]

sbte: some tidbit of info: it seems to only happen when I run the simulation speed at about 10/15 times the normal speed. I guess when the framerate starts being really low, there are some "jumps" now and then.

Try to start a game with an AI (added lag) and run "Engine.SetSimRate(20)". You should see units placed oddly around farms/resources.

Beyond that, patch seems to work fine.

[Kieran P]

I see the same thing on the latest SVN, so not related to this patch, and same as wraitii, seems to happen when SetSimRate is used.

[sbte]

@k776, there's a patch for it in #1858

[wraitii]

In 13252:

Simplify construction of the transformation matrix in GetInterpolatedTransform. Patch by sbte. Fixes #1854