Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#1891 closed defect (fixed)

[PATCH] Memory leaks in WaterManager

Reported by: historic_bruno Owned by: ben
Priority: Should Have Milestone: Alpha 14
Component: Core engine Keywords: patch
Cc: wraitii Patch:

Description

As reported in #1852 and here: 

[source\renderer\WaterManager.cpp:543]: (error) Memory leak: groundDirection
[source\renderer\WaterManager.cpp:543]: (error) Memory leak: waveForceHQ

In fact, groundDirection doesn't appear to be used for much of anything.

Attachments (1)

memleak.patch​ (439 bytes ) - added by Markus 11 years ago.
Readd delete[] waveForceHQ;

Download all attachments as: .zip

Change History (9)

comment:1 by ben, 11 years ago

Owner: set to ben
Resolution: → fixed
Status: new → closed

In 13337:

Fixes memory leak and removes unused code in WaterManager, fixes #1891, refs #1852

comment:2 by historic_bruno, 11 years ago

Milestone: Backlog → Alpha 14

comment:3 by Markus, 11 years ago

Cc: m4rkusxxl@… added
Resolution: fixed
Status: closed → reopened

Actually [13374] removed part of the fix (delete[] waveForceHQ;)

by Markus, 11 years ago

Attachment: memleak.patch​ added

Readd delete[] waveForceHQ;

comment:4 by Markus, 11 years ago

Cc: m4rkusxxl@… removed

comment:5 by Markus, 11 years ago

Keywords: review patch added

comment:6 by Markus, 11 years ago

Summary: Memory leaks in WaterManager → [PATCH] Memory leaks in WaterManager

comment:7 by wraitii, 11 years ago

Resolution: → fixed
Status: reopened → closed

In 13411:

Fixes a fix about a fix on the waterManager. Fixes #1891

comment:8 by leper, 11 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.