[PATCH] display the current number of garrisoned units when trying to garrison more units

[mimo]

When garrisoning units, there is no convenient way to know what is the capacity of the building and how many units are already garrisoned. Presently, we have to select the building we want to garrison in (so losing our units selection) and then reselect the units. Not really practical if not in the same portion of the map. Here is a simple patch to display a tooltip with these information when we are about to garrison units.

[alpha123]

This looks very good. Two minor things:

• The current message is very verbose, it would be great if you changed it to something like "Current garrison: 5/20" which is much easier to understand at a glance.
• A nice extra feature would be to make either the numbers or the whole tooltip orange if the building is full. That way it's easy to tell where you can or can't garrison.

[mimo]

OK for these two changes. Here is a modified version of the patch.

[alpha123]

Excellent. This looks good, although there are 2 very minor issues:

• In English there is no space between a colon and the word before it, so the message should be "Current garrison: 0/20" instead of the "Current garrison : 0 / 20" (which is the current message). Just a minor grammatical thing.
• tooltip = "[color=\"orange\"]" + tooltip; should have an extra + "[/color]"; so that the tags are properly formed (each opening tag should have a matching end one). The parser seems to accept it anyway however.

Also, I noticed that this only appears when you hold Ctrl to garrison, not when using the garrison button in the unit commands panel or when setting a rally point. Both of those should display the current/max capacity as well.

[mimo]

You are right about the missing color. That's strange that the parser accept it. For the english, I trust you. So I've just replaced the patch by a corrected version.

For the garrison button, I never use it, so I just forget it. I can try to implement also something here. For the rally point, what do you mean exactly ?

[mimo]

In fact, the garrison button change was trivial. It is now included.

[mimo]

And a last version with the rally point also included

[alpha123]

I tested it, looked over the code, and this seems ready to commit. Nice work. :)

[leper]

In 13361:

Display number of garrisoned units when trying to garrison. Patch by mimo. Fixes #1915.

[leper]

Thanks for the patch.