Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#2187 closed defect (fixed)

[PATCH] Remove EntityLimitsChanger

Reported by: sanderd17 Owned by: sanderd17
Priority: Should Have Milestone: Alpha 16
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

The EntityLimitsChanger component is unnecessary.

Instead, the information should be present in the EntityLimits component. The base working should be with classes, and every time a new entity is made (or one is destroyed), the limit should be checked.

As extension, the limit tooltip should be extended to include the classes that are limiting the creation of that entity.

Attachments (1)

entityLimits.diff (18.7 KB ) - added by sanderd17 11 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by leper, 11 years ago

Cc: simple added

comment:2 by leper, 11 years ago

Cc: simple removed
Keywords: simple added

comment:3 by historic_bruno, 11 years ago

How the new EntityLimits could look:

  <EntityLimits>
    <LimitMultiplier>1.0</LimitMultiplier>
    <Limits>
      <DefenseTower>30</DefenseTower>
        ...
      <Library>1</Library>
      <Field>
        <Limit>0</Limit>
        <CategoryLimits>
          <Farmstead>8</Farmstead>
        </CategoryLimits>
      </Field>
      <Lighthouse>1</Lighthouse>
    </Limits>
  </EntityLimits>

comment:4 by ben, 11 years ago

In 13964:

Reverts field limits from r13909 until we can fix AI and UI problems, refs #2187

by sanderd17, 11 years ago

Attachment: entityLimits.diff added

comment:5 by sanderd17, 11 years ago

Keywords: patch review added; simple removed
Milestone: BacklogAlpha 15

I opted to put it in a separate list, as IMO it wasn't nice to have a difference between <Cat>5</Cat> and <Cat><Limit>5</Limit></Cat>.

The UI is also automatically updated, and the AI can access the information.

comment:6 by historic_bruno, 11 years ago

Summary: Remove EntityLimitsChanger[PATCH] Remove EntityLimitsChanger

comment:7 by leper, 10 years ago

Milestone: Alpha 15Alpha 16

comment:8 by sanderd17, 10 years ago

Owner: set to sanderd17
Resolution: fixed
Status: newclosed

In 14408:

define the limit changing elements together with the limits, so they can be queried by the GUI and the AI. Fixes #2187

comment:9 by sanderd17, 10 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.