Opened 11 years ago

Closed 11 years ago

#2199 closed defect (fixed)

[PATCH] variable overwritten

Reported by: mimo Owned by: ben
Priority: Should Have Milestone: Alpha 15
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

in gui/session/unit_commands.js, the variable selection is initialised in line 215, but then redefined in line 526 and then used again line 730, but with the first definition expected.

Attachments (1)

unit_commands.diff​ (2.0 KB ) - added by Itms 11 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 by Itms, 11 years ago

Keywords: review patch added
Milestone: Backlog → Alpha 15
Summary: variable overwritten → [PATCH] variable overwritten

Indeed.

by Itms, 11 years ago

Attachment: unit_commands.diff​ added

comment:2 by historic_bruno, 11 years ago

Component: Core engine → UI & Simulation
Keywords: review removed

Thanks for the patch, that is a very subtle bug and a good catch :)

comment:3 by ben, 11 years ago

Owner: set to ben
Resolution: → fixed
Status: new → closed

In 13982:

Fixes variable name conflict in session UI, patch by Itms, fixes #2199

Note: See TracTickets for help on using tickets.