Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#2308 closed defect (fixed)

Add proper license header and tests to hash functions for the lobby

Reported by: leper Owned by: Josh
Priority: Should Have Milestone: Alpha 16
Component: Multiplayer lobby Keywords:
Cc: Patch:

Description

We should add the proper license header to pbkdf2 and hmac_sha256 from sha.cpp. IIRC those are from OpenBSD.

Those functions also need some tests to verify that they do what they should. (Related: r14123)

Change History (12)

comment:1 by Josh, 10 years ago

The tests can wait for Alpha 16. I'll try to straighten out the licence headers tonight.

comment:2 by JoshuaJB, 10 years ago

In 14349:

Add proper licence header and remove tyedefs in sha.cpp/h. Refs #2308

comment:3 by Josh, 10 years ago

Milestone: Alpha 15Alpha 16
Priority: Release BlockerShould Have

comment:4 by JoshuaJB, 10 years ago

In 14350:

Seperate differently licenced portions of sha.cpp/h into pkcs5_pdkdf2.cpp/h and remove some extra std includes in sha.cpp. Refs #2308

comment:5 by leper, 10 years ago

It'd also be nice to move all of that code somewhere were it makes sense (and it is easily seen that we did take that from somewhere else (like the stuff in third_party)), but that can be done for A16.

comment:6 by ben, 10 years ago

In 14357:

Updates license files for gloox, MiniUPnPc, and pkcs5_pbkdf2. Refs #2308

comment:7 by Josh, 10 years ago

Owner: set to Josh
Status: newassigned

comment:8 by JoshuaJB, 10 years ago

Resolution: fixed
Status: assignedclosed

In 14595:

Move lobby encryption code to third_party/encryption and add tests. Fixes #2308

comment:9 by historic_bruno, 10 years ago

Is it intentional that the header files are MIT licensed instead of GPL 2 or later? I guess it's not a problem if there's a reason, but it's somewhat out of place inside source/.

comment:10 by JoshuaJB, 10 years ago

In 14602:

Change the licence of sha.h to match the licence of sha.cpp. Refs #2308

comment:11 by Josh, 10 years ago

Thanks for catching that, I changed sha.h to GPL2+ so it matches sha.cpp but I'm going to leave the other header as MIT so it best matches its cpp file.

comment:12 by ben, 10 years ago

In 14617:

Updates LICENSE.txt for r14602, refs #2308.
Sets svn:ignore property on generated cpp from encryption tests.

Note: See TracTickets for help on using tickets.