[PATCH] Units loose orders after town bell (alert)

[Michael]

In a special case units lose their orders after the bell was deactivated:

Steps to reproduce:

• give citizens a job (f.e. get some food)
• ring the TWO levels of the alert fast one after each other
• Stop the alert before the citizens reach the shelter

--> They will go to the RallyPoint

[Michael]

Checks, if a unit is already on its way to the garrison and if, don't send it again.

[Itms]

I handled the case in a previous version of the bell, I forgot it there.

Anyway, I think it would be clearer this way (see attached patch). Thanks for finding the issue !

[Michael]

Replying to Itms:

I handled the case in a previous version of the bell, I forgot it there.

Anyway, I think it would be clearer this way (see attached patch). Thanks for finding the issue !

Yes, looks better. I did not found this function. :)

[Michael]

There's another problem:

If you produce units after the alert is active, they do not go into the garrison.

Or is that a feature ?

[Itms]

Let's say it's a missing feature. ;-)

But it's a good idea, and I'm wondering if the produce-then-garrison feature was present in the game when I worked on the alert.

If you want, I can work on this feature, knowing the code I think I can do it rather quickly.

[Michael]

Missing feature is good.

Yes, I would like that. I already tried to add it by myself but until now it only works for units which where produced in the civic center.

[Itms]

See #2342 then :)

Anyway, this patch is ready to commit.

[mimo]

In 14484:

fixes #2340, patch by itms

[mimo]

Thanks boeseRaupe and Itms for the patch