[PATCH] Check, if save game has the correct version.

[Michael]

Before loading a savegame, the game should check, if the savegame has the correct major version.

[Michael]

Checks the major version of the save game.

[Michael]

The patch checks, if the save game version is correct and if not disables the entry in the list.

TODO:

• define "warncolor" like "textcolor" is defined (I can not find that...)
• Maybe AddItem Function is not working or I'm doing something wrong.

[Michael]

Incompatible savegame for testing.

[mimo]

Thanks for the patch. I had a look at it, and I'm not convinced by the disabling of entries. I think we should warn the player that its saved games will certainly fail, but we should still leave him the possibility to try if he really wants to. I would then suggest to only display the incompatible games with a different color, but keep them selectable. Another possibility would be, as I've done for ​http://trac.wildfiregames.com/ticket/2385 , to have a checkbox to display only the compatible games or all. In addition, this would shorten a lot the patch.

In fact, as both patches are very similar, I can combine them to make them more consistent. The pending point is to agree on how we want to display the saved games: my preference would be to

• display by default only the saved games with the same mod (with a checkbox to display all saved games if wanted)
• display the saved games with a different major version in red, but keep them selectable

[Michael]

Replying to mimo:

Thanks for the patch. I had a look at it, and I'm not convinced by the disabling of entries. I think we should warn the player that its saved games will certainly fail, but we should still leave him the possibility to try if he really wants to. I would then suggest to only display the incompatible games with a different color, but keep them selectable. Another possibility would be, as I've done for ​http://trac.wildfiregames.com/ticket/2385 , to have a checkbox to display only the compatible games or all. In addition, this would shorten a lot the patch.

What I wanted to achieve was that incomp. save games do not disappear completely from the list because the player would wonder where his save games went. It's also ok to let them selectable and just display them in another color. In this case I would suggest to add an additional warning, if the player tries to load a save game with a different major version.

In fact, as both patches are very similar, I can combine them to make them more consistent.

Sounds good.

The pending point is to agree on how we want to display the saved games: my preference would be to

• display by default only the saved games with the same mod (with a checkbox to display all saved games if wanted)
• display the saved games with a different major version in red, but keep them selectable

I agree to you and to make it even more consistent I suggest:

• display by default only save games with the same mod and compatible onces
• add one check box for adding mods and incomp. onces or make for each kind a own one
• display inc. and wrong mod save games in different color
• warn the player, if he tries to load a "wrong" save game

[mimo]

In 14630:

check version and mods before loading a file, fixes #2361 and #2385.

[mimo]

Thanks boeseRaupe for the patch.