Changes between Initial Version and Version 1 of Ticket #2372


Ignore:
Timestamp:
Jan 12, 2014, 6:59:32 PM (10 years ago)
Author:
wraitii
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2372 – Description

    initial v1  
    1 The new SpiderMonkey (#1886) prints more warnings and errors about potentially buggy code.
    2 The idea is to have a close look at all these warnings and fix them in a sensible way instead of just trying to get rid of them somehow. If you know any of the affected files especially well or if you're otherwise interested to help, feel free! :)
    3 I'll focus on other TODOs for the upgrade first, but if a contributor without commit access proposes a fix, I'll review it quickly (you don't have to fix all warnings at once).
     1The new SpiderMonkey (#1886) prints more warnings and errors about potentially buggy code. The idea is to have a close look at all these warnings and fix them in a sensible way instead of just trying to get rid of them somehow. If you know any of the affected files especially well or if you're otherwise interested to help, feel free! :) I'll focus on other TODOs for the upgrade first, but if a contributor without commit access proposes a fix, I'll review it quickly (you don't have to fix all warnings at once).
    42
    53{{{
    6 WARNING: JavaScript warning: gui/gamesetup/gamesetup.js line 475 reference to undefined property civ.SelectableInGameSetup
    7 WARNING: JavaScript warning: gui/gamesetup/gamesetup.js line 945 reference to undefined property mapSettings.Size
     4WARNING: JavaScript warning: simulation/helpers/Commands.js line 223 reference to undefined property cmd.metadata
     5WARNING: JavaScript warning: simulation/components/UnitAI.js line 5603 mistyped ; after conditional?
    86WARNING: JavaScript warning: simulation/components/UnitAI.js line 5603 mistyped ; after conditional?
    97WARNING: JavaScript warning: simulation/components/TechnologyManager.js line 123 reference to undefined property template.requirements
     8WARNING: JavaScript warning: simulation/components/ProductionQueue.js line 540 reference to undefined property data.target
     9WARNING: JavaScript warning: simulation/components/ProductionQueue.js line 111 reference to undefined property template.Promotion
     10WARNING: JavaScript warning: simulation/components/Player.js line 479 reference to undefined property this.diplomacy[id]
    1011WARNING: JavaScript warning: simulation/components/Player.js line 386 reference to undefined property this.diplomacy[idx]
    11 WARNING: JavaScript warning: simulation/components/Player.js line 479 reference to undefined property this.diplomacy[id]
    12 WARNING: JavaScript warning: simulation/components/ProductionQueue.js line 111 reference to undefined property template.Promotion
     12WARNING: JavaScript warning: simulation/components/GuiInterface.js line 928 reference to undefined property this.entsRallyPointsDisplayed
     13WARNING: JavaScript warning: simulation/components/GuiInterface.js line 664 reference to undefined property template.icon
     14WARNING: JavaScript warning: simulation/components/BattleDetection.js line 52 reference to undefined property this.state
     15WARNING: JavaScript warning: simulation/ai/common-api/terrain-analysis-pathfinder.js line 208 reference to undefined property this.index
     16WARNING: JavaScript warning: simulation/ai/common-api/map-module.js line 78 reference to undefined property this.map[(x + (y * this.width))]
     17WARNING: JavaScript warning: simulation/ai/aegis/headquarters.js line 450 reference to undefined property this.wantedRates
     18WARNING: JavaScript warning: simulation/ai/aegis/base-manager.js line 904 reference to undefined property this.targetNumBuilders
     19WARNING: JavaScript warning: simulation/ai/aegis/base-manager.js line 587 reference to undefined property gameState.playedTurn
    1320WARNING: JavaScript warning: simulation/ai/aegis/aegis.js line 48 reference to undefined property sharedScript.events
    14 WARNING: JavaScript warning: simulation/ai/common-api/terrain-analysis-pathfinder.js line 208 reference to undefined property this.index
    15 WARNING: JavaScript warning: simulation/components/BattleDetection.js line 52 reference to undefined property this.state
     21WARNING: JavaScript warning: gui/session/selection_details.js line 214 reference to undefined property entState.attack
     22WARNING: JavaScript warning: gui/session/input.js line 494 reference to undefined property entState.rallyPoint
     23WARNING: JavaScript warning: gui/session/input.js line 487 reference to undefined property entState.unitAI
     24WARNING: JavaScript warning: gui/session/input.js line 422 reference to undefined property entState.resourceGatherRates
    1625WARNING: JavaScript warning: gui/session/input.js line 1086 reference to undefined property ev.hotkey
    17 WARNING: JavaScript warning: simulation/ai/aegis/headquarters.js line 450 reference to undefined property this.wantedRates
    18 WARNING: JavaScript warning: simulation/ai/aegis/base-manager.js line 587 reference to undefined property gameState.playedTurn
    19 WARNING: JavaScript warning: simulation/components/GuiInterface.js line 928 reference to undefined property this.entsRallyPointsDisplayed
    20 WARNING: JavaScript warning: simulation/ai/aegis/base-manager.js line 904 reference to undefined property this.targetNumBuilders
    21 WARNING: JavaScript warning: simulation/components/GuiInterface.js line 664 reference to undefined property template.icon
    22 WARNING: JavaScript warning: gui/session/input.js line 487 reference to undefined property entState.unitAI
    23 WARNING: JavaScript warning: simulation/helpers/Commands.js line 223 reference to undefined property cmd.metadata
    24 WARNING: JavaScript warning: simulation/ai/common-api/map-module.js line 78 reference to undefined property this.map[(x + (y * this.width))]
    25 WARNING: JavaScript warning: gui/session/input.js line 422 reference to undefined property entState.resourceGatherRates
    26 WARNING: JavaScript warning: simulation/components/ProductionQueue.js line 540 reference to undefined property data.target
    27 WARNING: JavaScript warning: gui/session/input.js line 494 reference to undefined property entState.rallyPoint
    28 WARNING: JavaScript warning: gui/session/selection_details.js line 214 reference to undefined property entState.attack
     26WARNING: JavaScript warning: gui/lobby/lobby.js line 580 reference to undefined property msg.from
    2927WARNING: JavaScript warning: gui/lobby/lobby.js line 370 reference to undefined property message.from
    30 WARNING: JavaScript warning: gui/lobby/lobby.js line 580 reference to undefined property msg.from
    31 WARNING: JavaScript warning: simulation/components/UnitAI.js line 5603 mistyped ; after conditional?
     28WARNING: JavaScript warning: gui/lobby/lobby.js line 370 reference to undefined property message.from
     29WARNING: JavaScript warning: gui/gamesetup/gamesetup.js line 951 reference to undefined property mapSettings.PopulationCap
     30WARNING: JavaScript warning: gui/gamesetup/gamesetup.js line 945 reference to undefined property mapSettings.Size
    3231WARNING: JavaScript warning: gui/gamesetup/gamesetup.js line 475 reference to undefined property civ.SelectableInGameSetup
    33 WARNING: JavaScript warning: gui/gamesetup/gamesetup.js line 951 reference to undefined property mapSettings.PopulationCap
     32WARNING: JavaScript warning: gui/gamesetup/gamesetup.js line 475 reference to undefined property civ.SelectableInGameSetup
    3433WARNING: JavaScript warning: gui/gamesetup/gamesetup.js line 1422 reference to undefined property msg.text
    35 WARNING: JavaScript warning: gui/lobby/lobby.js line 370 reference to undefined property message.from
    3634}}}