QA for alpha17

[fabio]

Some minor issues testing current SVN:

• the save game menu still uses the old graphics;
• when pressing Chat from the game menu "Team only" is not translated;
• developer overlay should be less transparent (text is hardy readable on a bright terrain);
• it's not clear the difference between Resign and Exit game menu. Maybe one (the first) should be dropped?
• when exiting the option menu from the game the game should not be still paused;
• "Help with the translation button!" is not capitalized, but "Report a Bug" under it it is. Similar issues are all over the game;
• some buttons are not consistently placed: confirmation buttons and cancel buttons should always be in the same position. E.g. confirmation buttons on the left, cancel buttons on the right. This is not always the case, e.g. the "Connect" (confirmation) button for connecting to the Multiplayer Lobby is on the right, while most other confirmation buttons are on the left.

[Stan]

I think you should automatically resign when exiting. Unless that prevents users that are disconnected to get back in the game.

[scythetwirler]

I'll take care of the first bullet when I get home in a couple hours.

[sanderd17]

AFAIK, the resign resigns you immediately, while the exit gives you some time to come back (like a crashing game does).

[scythetwirler]

In 15068:

Converts the save dialog to the modern UI. Refs #2507.

[Josh]

In 15071:

Update AI descriptions, closes #2500. Also correct some capitalization and developer overlay transparency for #2507.

[JoshuaJB]

In 15072:

Make game automatically resume after closing the options menu. Refs #2507

[Josh]

In 15074:

(The changeset message doesn't reference this ticket)

[fabio]

Replying to Josh:

Also correct some capitalization

The "Learn To Play" should also be changed to "Learn to Play" to be consistent.

[fabio]

Replying to Josh:

In 15074:

(The changeset message doesn't reference this ticket)

The confirmation buttons of Resign and Exit during gameplay should also be swapped.

[fabio]

Replying to sanderd17:

AFAIK, the resign resigns you immediately, while the exit gives you some time to come back (like a crashing game does).

So the Exit button could be removed? Or there are cases where it may be useful?

[Stan]

Ragequit, that´s nearly all if the moms asks him to stop he could resign unless he only disconnects for a short time.

But why is this ticket a so big issue i mean most people won ´t even notice.

[sanderd17]

Replying to stanislas69:

But why is this ticket a so big issue i mean most people won ´t even notice.

They do notice. One of the most heard comments in the lobby is "why didn't this game get rated?". There are multiple causes though. Like ragequits, but also more technical stuff like timeouts, or design choices (s.a. only rating 1v1 games).

[Josh]

Replying to sanderd17:

Replying to stanislas69:

But why is this ticket a so big issue i mean most people won ´t even notice.

They do notice. One of the most heard comments in the lobby is "why didn't this game get rated?". There are multiple causes though. Like ragequits, but also more technical stuff like timeouts, or design choices (s.a. only rating 1v1 games).

Timeouts have been fixed, and the system is designed to support rating almost any game. ( The ELO implementation just hasn't been expanded to support anything but 1 vs. 1 games.)

[Stan]

I meant the typos stuff :)

[scythetwirler]

Replying to fabio:

it's not clear the difference between Resing and Exit game menu. Maybe one (the first) should be dropped?

I think it's reasonably clear; resign is self-explanatory and exit navigates you away from the in-game interface. Non-newer players will use the resign button to resign instead of clicking exit and possibly clicking the wrong buttons (for resigning or coming back later).

Also, @stanislas69, we will not be able to incorporate your fix due to string freeze. :( Also, the buttons seemed have already been switched in r15096.

[fabio]

Replying to scythetwirler:

Replying to fabio:

it's not clear the difference between Resing and Exit game menu. Maybe one (the first) should be dropped?

I think it's reasonably clear; resign is self-explanatory and exit navigates you away from the in-game interface. Non-newer players will use the resign button to resign instead of clicking exit and possibly clicking the wrong buttons (for resigning or coming back later).

I first thought resign would quit the current match, while exit would close the 0 ad application, I don't remember seeing games with this behavior.

Also, @stanislas69, we will not be able to incorporate your fix due to string freeze. :( Also, the buttons seemed have already been switched in r15096.

This can be committed independent of the string freeze, because the string is not translated anyway.

[ben]

In 15193:

Removes errant text from GUI XML files, fixes some untranslated text per Internationalization. Refs #2507

[fabio]

Most of the issue of this problem are fixed. Still to be eventually discussed but not urgent:

• capitalizations of menu items;
• periods at phrase end;
• usefulness of Exit and Resign game button.