Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#2547 closed defect (fixed)

[PATCH] Some data in the lobby is not being localized

Reported by: Adrián Chaves Owned by: gallaecio
Priority: Should Have Milestone: Alpha 18
Component: Internationalization & Localization Keywords: patch
Cc: Patch:

Description (last modified by Adrián Chaves)

Attachments (3)

lobbyUnstranslatedStringsAsNonHost.png​ (995.3 KB ) - added by Adrián Chaves 10 years ago.
lobbyUnstranslatedStringsAsNonHost-20141209.png​ (750.6 KB ) - added by Adrián Chaves 9 years ago.
Current state as of 2014-12-09.
2547.patch​ (1.9 KB ) - added by Adrián Chaves 9 years ago.
Solution based on existing code.

Download all attachments as: .zip

Change History (15)

by Adrián Chaves, 10 years ago

Attachment: lobbyUnstranslatedStringsAsNonHost.png​ added

comment:1 by Adrián Chaves, 10 years ago

Description: modified (diff)

comment:2 by Itms, 10 years ago

Milestone: Alpha 17 → Alpha 18

comment:3 by historic_bruno, 10 years ago

So, there are a number of issues with the lobby and translations:

  • Map sizes in the game list are a "short" form that isn't currently translated, the script splits the English name by spaces. I think that's a bad idea for translation, maybe we need a separate short form of map sizes?
  • Map type is converted from lower case with toTitleCase, for display purposes, this also seems like a bad idea for translations
  • There are spacing issues even at fullscreen in the map details panel(s), the colon seems to cause alignment issues
  • The welcome message isn't currently translated - that comes from the lobby server, any idea how to pull in this message for translation?
Last edited 10 years ago by historic_bruno (previous) (diff)

comment:4 by ben, 10 years ago

In 15752:

Fixes some untranslated text in the multiplayer lobby (map name, type, and description), refs #2547

in reply to:  3 comment:5 by scythetwirler, 10 years ago

Replying to historic_bruno:

  • The welcome message isn't currently translated - that comes from the lobby server, any idea how to pull in this message for translation?

See #2489. Both the lobby subject and lobby message should use the same xml-like structure.

Last edited 10 years ago by scythetwirler (previous) (diff)

comment:6 by Adrián Chaves, 9 years ago

Owner: set to Adrián Chaves

comment:7 by Adrián Chaves, 9 years ago

Status: new → assigned

by Adrián Chaves, 9 years ago

Attachment: lobbyUnstranslatedStringsAsNonHost-20141209.png​ added

Current state as of 2014-12-09.

comment:8 by Adrián Chaves, 9 years ago

Currently everything is being translated but the map size on the sidebar. Once that is fixed, this issue is fixed as well.

by Adrián Chaves, 9 years ago

Attachment: 2547.patch​ added

Solution based on existing code.

comment:9 by Adrián Chaves, 9 years ago

Keywords: simple review patch added
Owner: Adrián Chaves removed
Status: assigned → new
Summary: Some data in the lobby is not being localized → [PATCH] Some data in the lobby is not being localized

comment:10 by Adrián Chaves, 9 years ago

I noticed that the map size was properly translated in the list of the middle, so I refactorized the code used for the list into a new function, and I applied that function to the sidebar as well.

comment:11 by gallaecio, 9 years ago

Owner: set to gallaecio
Resolution: → fixed
Status: new → closed

In 16031:

Fixes the translation of the map size in the rihgt sidebar of the lobby

Fixes #2547

comment:12 by leper, 9 years ago

Keywords: simple review removed
Note: See TracTickets for help on using tickets.