[PATCH] in team result screen: wrong map discovered total percentage

[Tom Brewe]

When playing in a team the calculated amount of map discovered is being added, resulting in eg: Player 1: 60% Player 2: 70% Total: 130%

Better would be to have a total of 70%. So calculating the max() instead of the sum.

[leper]

I'm not sure if 70% is the correct value here, as it could easily be 100% or anything between 100 and 70.

[Itms]

I'll push this to a18, but I'd like to take a look at it later, as I recently worked on SoD and FoW.

[Itms]

Here is a proposal. I modified the way the range manager computes the exploration percentage: before it used a cache, now it computes it all when requested. However this could be bad for performance, so I made sure this is not performed too often: the AI was requesting the extended simulation state in one place, which is not needed if I'm not mistaken.

Now for a silly question: I couldn't find the total value in the summary screen, does it appear only in multiplayer games?

[Itms]

Here is a working version, tested in-game, and commented enough to avoid problems. I also added the barter prices to the basic simulation state so that AIs can use it.

[Itms]

In 16071:

Compute the actual percentage of map explored by the team in the summary screen.

Fixes #2587.