tinygettext: collision in add_translation

[Adrián Chaves]

Since the split of the translation files, tinygettext throws warnings such as:

tinygettext: collision in add_translation: 'Chalkaspides' -> 'Chalkaspides' vs 'Chalkaspides'

Those warning should only be printed if the transations are different.

[sanderd17]

IMO, we shouldn't require a string to be translated twice (and end up with conflicting strings, just because they're possible to translate in two ways). So the strings should only be in the pot where it appeared first.

[Yves]

There's a similar issue with plural translations. I've debugged memory corruption on the history/civinfo screen today. The cause was the translation of "Special Building" which is in the *templates-buildings.po and in *gui-other.po. In the latter, it also contains translations for plural forms but not in the former. The translation in the dictionary ends up without the plural forms and it crashes when it tries to find them.

I've worked around the crash and made it print an error to the console instead in r15493.

[Adrián Chaves]

Fixed in r16138

[leper]

In 16140:

Improve r16138. Refs #2637.