[PATCH] ActorEditor, regardless of configuration, always links against Release libAtlasUI.dylib

[Echelon9]

See output below from Mac otools when inspecting binaries/system/ActorEditor_dbg:

$ otool -L binaries/system/ActorEditor_dbg 
binaries/system/ActorEditor_dbg:
	@executable_path/libAtlasUI.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 120.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1197.1.1)

Note that it is linked against libAtlasUI.dylib, not libAtlasUI_dbg.dylib.

ActorEditor is unable to open on Mac in the Debug configuration, without this fix.

[Echelon9]

I made an attempted fix by editing the premake4.lua script as follows. In essence, this was based on precedent within the same file for different Debug and Release configuration link settings.

Index: build/premake/premake4.lua
===================================================================
--- build/premake/premake4.lua	(revision 15464)
+++ build/premake/premake4.lua	(working copy)
@@ -1169,7 +1169,11 @@
 		links { "AtlasObject" }
 	end
 
-	links { "AtlasUI" }
+	configuration "Debug"
+		links { "AtlasUI_dbg" }
+	configuration "Release"
+		links { "AtlasUI" }
+	configuration { }
 
 end

Unfortunately, with this edit, ./clean-workspaces plus ./update-workspaces and a new make build the same linking error occurs.

[Echelon9]

Fix for premake sharedlib link issues on Mac OS X

[Echelon9]

Scratch that rather silly early attempt at fixing the issue.

Have gone to read the premake docs, and the issue is in the deliberate install_name command invocation, as premake does not yet fully support that option natively on OS X.

Revised patch attached, which I've confirmed resolves the linking problems with Debug configuration on Mac.

With the patch:

$ otool -L ActorEditor_dbg 
ActorEditor_dbg:
	@executable_path/libAtlasUI_dbg.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 120.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1197.1.1)

./ActorEditor_dbg also runs properly.

[Josh]

Looks good. It will be committed later today.

[JoshuaJB]

In 15608:

Link actor editor built in debug mode to debug version of atlasUI. Fixes #2655. Patch by Echelon9.

[Josh]

Thanks for the patch.