Opened 10 years ago

Last modified 10 years ago

#2810 closed defect

Race condition found in FCollada Makefile — at Initial Version

Reported by: Guido Falsi Owned by:
Priority: Must Have Milestone: Alpha 17
Component: Build & Packages Keywords: fcollada patch
Cc: Patch:

Description

While testing on FreeBSD I found a race condition in the fcollada Makefile:

all: output_dirs output/libFColladaSD.a output/libFColladaSR.a install

as it is there is no warranty the output_dirs target will be executed before the other ones or thir descendants, so sometimes the build fails due to missin directories.

I fixed it sith the attached patch, which adds output_dirs as an order only dependency on all relevant targets, wwarranting it wwill be exeecuted first.

It fixed the probem for me.

Change History (1)

by Guido Falsi, 10 years ago

Race condition fix

Note: See TracTickets for help on using tickets.