Opened 10 years ago
Last modified 10 years ago
#2810 closed defect
Race condition found in FCollada Makefile — at Version 1
| Reported by: | Guido Falsi | Owned by: | |
|---|---|---|---|
| Priority: | Must Have | Milestone: | Alpha 17 |
| Component: | Build & Packages | Keywords: | fcollada patch |
| Cc: | Patch: |
Description (last modified by )
While testing on FreeBSD I found a race condition in the fcollada Makefile:
all: output_dirs output/libFColladaSD.a output/libFColladaSR.a install
as it is there is no warranty the output_dirs target will be executed before the other ones or their descendants, so sometimes the build fails due to missing directories.
I fixed it with the attached patch, which adds output_dirs as an order only dependency on all relevant targets, warranting it will be executed first.
It fixed the probem for me.
Change History (2)
by , 10 years ago
| Attachment: | patch-libraries__source__fcollada__src__Makefile added |
|---|
comment:1 by , 10 years ago
| Description: | modified (diff) |
|---|
Note:
See TracTickets
for help on using tickets.
Race condition fix