[PATCH][ATLAS]Add a unsaved changes check on exiting Atlas

[Niek]

It would be nice to ask for confirmation on exiting Atlas if there are unsaved changes (and it saves me for wasting more hours on Scenario Designing just because I forgot to save the map :))

[Niek]

The patch provided by trompetin17 works as expected. Modify the map and you'll get a confirmation box when you're trying to exit with unsaved changes. There is one thing I however want to add, if you undo all the way back to a saved state it still comes up with that warning (while technically it is saved, it only is modified and reverted afterwards)

[Niek]

I think this is a proper way to handle the behavior suggested above:

• Keep track of the undo history.
• Mark the first map state as the initial state (this is the state when you just loaded the map, without any changes.
• If you save the map, mark that state as the saved state. If the saved state is not present in the undo history (either because you didn't save the map yet or because you undo-ed and made changes again) don't care about it (no need to check the file system if the current state is exactly the state of the saved map). If it isn't in the undo history you won't realistically reach the exact state (without reloading the map) anyway.

[Itms]

After looking more closely at the code, I think niektb's suggestion is better.

Indeed, you had to add manually a notification to the editor for each change, so if someone adds a new way to change the map, they'll have to add this notification too. I think the undo/redo approach is saner.

About the style, I'll just suggest some English changes, and I'll review seriously the future version of the patch, as you'll have to change a significant part of your code.

• m_changesWithoutSave -> m_needsSave or something like this
• "The map has not been saved... continue closing?" -> "You have unsaved changes. Are you sure you want to quit?" is more standard
• "Please confirm" -> "Discard unsaved changes?" is also more standard

¡Gracias por trabajar sobre eso! ;-)

[trompetin17]

Done, could you review again please :)

[Itms]

Ok, I tested the patch. I really like how it is now, just some style comments:

• Beware the trailing spaces on lines 581, 748, 773, 788
• your comments "change the flag" are useless, and I'd write "Check for unsaved changes" on line 572 (also please write //(space)Your text)

Now, about the functionality, you should also perform the check when opening another map, or when creating a new one, etc. After that I think it will be ok :)

[trompetin17]

Itms, could you re-check, i added some configuration in my xcode about "indentation", hope this help.

And about functionality i added a check in "OnOpen", "OnMRUFile" and "OnImportHeightmap".

[Stan]

Is it necessary to add one for the RMG ?

[trompetin17]

Sorry what does mean RMG?

Replying to stanislas69:

Is it necessary to add one for the RMG ?

[trompetin17]

Itms, i made another change, could you re-re-re-review ? :$

[Stan]

Random map generation. =)

[trompetin17]

Added, thx for your warning

2819_dic.3.diff

Replying to stanislas69:

Random map generation. =)

[Itms]

In 16126:

Check for unsaved changes in Atlas. Patch by trompetin17, fixes #2819.

[Itms]

Thanks for the patch!