Infinite recursion when crashlog.txt can't be written

[Philip Taylor]

In debug.cpp, debug_WriteCrashlog tries to open crashlog.txt for writing. If it fails (e.g. it doesn't have write permission to that directory), it resets isBusy and then does WARN_RETURN, which calls debug_DisplayError, which calls debug_WriteCrashlog, and isBusy is false so it loops forever.

See ​http://ruby.pastebin.com/m53d88e4a for an example of this.

[Jan Wassenberg]

Fixed via tri-state bool :)

[Philip Taylor]

In r7053, I see you use volatile and cpu_CAS. Is that meant to be to make it thread-safe? If so, the static variable initialisation is not thread-safe and could break everything.

(Hmm, this ticket is an inappropriate place for this comment - maybe we need a better system for this kind of thing.)

[Jan Wassenberg]

Good point. Have fixed that, too.

[(none)]

Milestone Open Source Release deleted