mod selector is broken

[mimo]

It crashes (on linux kubuntu 14.04) with

WARNING: JavaScript warning: gui/modmod/modmod.js line 303 reference to undefined property mod.url ERROR: JavaScript error: gui/modmod/modmod.js line 303 TypeError: mod.url is undefined

filterMod@gui/modmod/modmod.js:303 generateModsList/<@gui/modmod/modmod.js:169 generateModsList@gui/modmod/modmod.js:163 generateModsLists@gui/modmod/modmod.js:71 applyFilters@gui/modmod/modmod.js:272 eventhandler36 (selectionchange)@modTypeFilter selectionchange:0 init@gui/modmod/modmod.js:52

ERROR: GUI page 'page_modmod.xml': Failed to call init() function IGUITextOwner.cpp(91): Assertion failed: "0 && (L"Trying to draw a Text Index within a IGUITextOwner that doesn't exist")" Assertion failed: "0 && (L"Trying to draw a Text Index within a IGUITextOwner that doesn't exist")" Location: IGUITextOwner.cpp:91 (DrawText)

[Niek]

What SDL version are you using?

[leper]

Just when opening it or when doing something specific? Just read failed to call init(). Any specific mods installed?

Should probably do some checks there, but having a nice testcase would help.

[mimo]

Thanks for the hint that it was probably due to one of the installed mods :-). It was in fact due to a mod with an incomplete mod.json (the line "url"= was missing). May-be we should have a warning message and just skip the mod in such a case ?

[Niek]

mimo, which mod? :)

[mimo]

don't panic, not from com :-) it was mine: I do my dev on Petra as a mod, but didn't know all lines in mod.json were mandatory.

[Niek]

phew :D

[leper]

Ah, so it is sort of the same as #2794. I'll handle it by skipping mods without that data (and logging it).

[leper]

In 15792:

Ignore mods (in the modmod) that do not specify required properties. Fixes #2822. Refs #2794.

Fixes description display if filters are used.