[PATCH] Errors upon spectators using team chat.

[scythetwirler]

Spectators using team chat will trigger errors on the actual players screens, but not the spectators.

[Casey]

So the idea is to get the errors to show up for the spectators or to remove the errors?

[leper]

How can hiding errors ever be a sensible solution?

[trompetin17]

does Spectators use a team chat? even if you can use, who is going to recieve, because a spectator doesn't have a team, does it?

btw Im guessing the problem happen here

if (g_Players[Engine.GetPlayerID()].team != g_Players[sender].team)

can Spectators use chat?

Replying to leper:

How can hiding errors ever be a sensible solution?

[trompetin17]

Observers only can use chat for global messages("message" or "/all message").

• TeamChat toggle is hidden to observer

[Itms]

Hi trompetin, the patch looks fine, however I don't like much the usage of your helper function without parameter (hideTeamOptionToObserver();). If you want to make the parameter "optional" you should check for it in the function to avoid strange behavior.

Also, as the function does not only hide the team to observers, but also toggles the checkbox, you should rename the function to something more general like updateTeamCheckbox.

Thanks for working on this!

[trompetin17]

Done :)

Replying to Itms:

Hi trompetin, the patch looks fine, however I don't like much the usage of your helper function without parameter (hideTeamOptionToObserver();). If you want to make the parameter "optional" you should check for it in the function to avoid strange behavior.

Also, as the function does not only hide the team to observers, but also toggles the checkbox, you should rename the function to something more general like updateTeamCheckbox.

Thanks for working on this!

[Itms]

In 16170:

Prevent observers from using the team chat. Patch by trompetin17, fixes #2879.

[Itms]

I committed the patch with slight changes:

• used let instead of var in updateTeamCheckbox
• instead of handling the case where the parameter is undefined, I called the function with the parameter set to false
• I added a comment in messages.js for clarity

Thanks for fixing the issue!

[leper]

In 16953:

Prevent observers from using most chat commands. Refs #2879.

Chat prefixed with /all could circumvent the check. Fix this by only allowing /me.
(Note that this is not a full solution, see #3270.)

Refactors the cheat and chat input code based on changes in some of elexis' patches.