Changes between Initial Version and Version 4 of Ticket #2907


Ignore:
Timestamp:
May 30, 2017, 1:31:27 AM (7 years ago)
Author:
Sandarac
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2907

    • Property Patch → Phab:D576
    • Property Milestone Alpha 18 → Work In Progress

  • Ticket #2907 – Description

    initial v4  
    1 [http://www.wildfiregames.com/forum/index.php?showtopic=18229&p=300144 As reported on the forums] the actor change technology does not apply to the [source:ps/trunk/binaries/data/mods/public/simulation/components/Fogging.js#L24 Fogging], [source:ps/trunk/binaries/data/mods/public/simulation/components/Health.js#L235 Health (corpse)], and [source:ps/trunk/binaries/data/mods/public/simulation/components/GuiInterface.js#L1141 placementPreview] cases.
    2 
     1[http://www.wildfiregames.com/forum/index.php?showtopic=18229&p=300144 As reported on the forums] the actor change technology does not apply to the [source:ps/trunk/binaries/data/mods/public/simulation/components/Fogging.js#L24 Fogging], [source:ps/trunk/binaries/data/mods/public/simulation/components/Health.js#L235 Health (corpse)], and [source:ps/trunk/binaries/data/mods/public/simulation/components/GuiInterface.js#L1141 placementPreview] cases.
    32`corpse|` and `preview|` templates both have the Identity component, but we don't apply technologies to them (see [source:ps/trunk/source/simulation2/system/ComponentManager.cpp#L1050 SendGlobalMessage()] (note that the comment should read `local` instead of `non-local`). The reasoning why we don't do that makes sense, and we need a different way for Fogging anyways, so using the same way for all of those cases makes sense.
    4 
    53We should add a function to set the actor to cmpVisualActor and use that to set the correct one in all three cases. The preview case should use cmpTechnologyManager's `ApplyModificationsTemplate()` to obtain the correct actor. I'm not sure if it is worth extra logic to handle the case where an actor changing technology is researched while the user is placing a building.