Opened 8 years ago

Closed 2 years ago

Last modified 2 years ago

#2907 closed defect (fixed)

VisualActor changes are not applied for building placement previews, corpses and fogged entities

Reported by: leper Owned by: wraitii
Priority: Nice to Have Milestone: Alpha 24
Component: Core engine Keywords: simple
Cc: Patch: Phab:D576

Description (last modified by Sandarac)

As reported on the forums the actor change technology does not apply to the Fogging, Health (corpse), and placementPreview cases. corpse| and preview| templates both have the Identity component, but we don't apply technologies to them (see SendGlobalMessage() (note that the comment should read local instead of non-local). The reasoning why we don't do that makes sense, and we need a different way for Fogging anyways, so using the same way for all of those cases makes sense. We should add a function to set the actor to cmpVisualActor and use that to set the correct one in all three cases. The preview case should use cmpTechnologyManager's ApplyModificationsTemplate() to obtain the correct actor. I'm not sure if it is worth extra logic to handle the case where an actor changing technology is researched while the user is placing a building.

Change History (7)

in reply to:  description comment:1 by historic_bruno, 8 years ago

Replying to leper:

I'm not sure if it is worth extra logic to handle the case where an actor changing technology is researched while the user is placing a building.

To the extent that appearance indicates something important about the building being previewed, I think it is worth it.

comment:2 by leper, 8 years ago

Milestone: Alpha 18Alpha 19

comment:3 by Itms, 8 years ago

Milestone: Alpha 19Backlog

comment:4 by Sandarac, 6 years ago

Description: modified (diff)
Milestone: BacklogWork In Progress
Patch: Phab:D576

comment:5 by wraitii, 2 years ago

Owner: set to wraitii
Resolution: fixed
Status: newclosed

In 24279:

Fix VisualActor tech changes for mirages

Correctly recompute the actor when something changes that could modify it (ownership change, ...).
Make sure mirages are updated when they reappear after being hidden.
Make sure foundations have proper identity classes.
Make sure mirages don't respond to value modifications in the visual component.
Clarify a few comments.

Earlier work by: Sandarac

Fixes #2907

Differential Revision: https://code.wildfiregames.com/D576

comment:6 by wraitii, 2 years ago

In 24347:

Make construction previews local entities (fix rP24279)

Identity classes where added to construction previews in D576 / rP24279. This meant they counted towarde entity limits, as they were not local entities.

This diff fixes that by making them local entities.

Thanks for s0600204 for raising the issue

Reported by: wowgetoffyourcellphone

Refs #2907

Differential Revision: https://code.wildfiregames.com/D3187

comment:7 by Stan`, 2 years ago

Milestone: Work In ProgressAlpha 24
Note: See TracTickets for help on using tickets.