Order.Flee: too much recursion

[brian]

Git revision: 2948aa76835e29e04a089fdc03457be6256b3eaf

ERROR: JavaScript error: simulation/helpers/Entity.js line 3 InternalError: too much recursion DistanceBetweenEntities@simulation/helpers/Entity.js:3 UnitAI.prototype.UnitFsmSpecOrder.Flee@simulation/components/UnitAI.js:392 FSM.prototype.ProcessMessage@simulation/helpers/FSM.js:274 UnitAI.prototype.FinishOrder@simulation/components/UnitAI.js:3483 UnitAI.prototype.UnitFsmSpecOrder.Flee@simulation/components/UnitAI.js:406 FSM.prototype.ProcessMessage@simulation/helpers/FSM.js:274 UnitAI.prototype.FinishOrder@simulation/components/UnitAI.js:3483 UnitAI.prototype.UnitFsmSpecOrder.Flee@simulation/components/UnitAI.js:406 FSM.prototype.ProcessMessage@simulation/helpers/FSM.js:274 UnitAI.prototype.FinishOrder@simulation/components/UnitAI.js:3483 UnitAI.prototype.UnitFsmSpecOrder.Flee@simulation/components/UnitAI.js:406 FSM.prototype.ProcessMessage@simulation/helpers/FSM.js:274 UnitAI.prototype.FinishOrder@simulation/components/UnitAI.js:3483 UnitAI.prototype.UnitFsmSpec["Ord...

ERROR: Script message handler OnMotionChanged failed

[mimo]

Nothing to do with AI. It seems to be a MP game without AI.

[brian]

Yes, it was a multiplayer game. Just had AI on the mind when I made the ticket.

[mimo]

In 16369:

do not apply multiple leavefoundation orders, fix #3010

[mimo]

There was already a check in UnitAI to prevent multiple leaveFoundation orders, but it was not effective as it was testing on the existence of a previous leaveFoundation order, but leaveFoundation orders are changed to Flee order as soon as they become active. I've nonetheless kept the test on leaveFoundation.