[PATCH] Cheats don't work in SP

[tau]

svn revision 16266

In singeplayer mode, cheats do not work.

[mimo]

Can you be more explicit: which one have you tried ? I've just tested one (wololo) and that works, at least on linux.

[tau]

I am on win7, tried 'back to the future', 'i am too busy', 'i want pizza'...

[tau]

(They are just being written on the screen as a normal chat message)

[mimo]

Yes, but you need to recompile because of some of the changes. You should wait for the next autobuild which should come soon.

[tau]

I did build it; and in fact noticed the issue some revisions ago, including an autobuild revision

[Itms]

Mh, maybe you disabled cheats for one game and now that the game settings are remembered they are still disabled?

[tau]

SP mode has no such setting at all, shouldn't they always work in SP? (In MP mode cheats work fine, if i switch them on.)

[Niek]

I can't reproduce it. (tried both on Windows 8.1 and 7). Cheats work just fine here.

[tau]

I actually have found what caused this; for some reason matchsettings.json didn't contain "CheatsEnabled":true setting, and this never was rewritten. Don't know yet how this happened though.

[Alex]

Although I couldn't imagine a case where cheats become disabled in singleplayer, have a patch.

[Itms]

In 16346:

Some hacks to fix game setup persisting problems, patch by @aBothe.
Fixes #3033, #3034.

The whole gamesetup.js system should be eventually re-factored to remove those hacks and to improve the robustness of the code: see #3049.

[Itms]

Thanks for the patches.