[PATCH] [REVIEW] Aegean Sea RMS: the river is passable on some map instances

[fcxSanya]

Aegean Sea is marked as a naval map (and introducing it on forum Spahbod ​wrote "<...> players who must build a navy to reach the enemy") and in some cases (with some settings/seeds) ships indeed are required in order to access the another riverbank. But some map instances have such islands/fords combination that the river becomes passable, what significantly affects gameplay.

Issue was noticed on A18 during the game and was further tested on r16533 in Atlas with the following results (I tested only seeds 0-9, what hopefully should be representative enough):

Small map size, 2 players Impassable river: seeds 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Medium map size, 2 players Impassable river: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Medium map size, 4 players Impassable river: seeds 0, 1, 3, 4, 5, 6, 7 Passable river: seeds 2, 8

Normal map size, 4 players Impassable river: seeds 0, 4, 7 Passable river: seeds 1, 2, 3, 5, 6, 8, 9

Large map size, 6 players Impassable river: seeds 0, 1, 4, 9 Passable river: seeds 2, 3, 5, 6, 7, 8

[FeXoR]

fcxSanya: Thanks for the report. I'll look into it.

[FeXoR]

Passability for unit seams to be defined by MaxWaterDepth in line 12 of binaries/data/mods/public/simulation/data/pathfinder.xml as 2 while the "undersea bumps" are set to -1.6 in line 413 in binaries/data/mods/public/maps/randomaegean_sea.js.

I think the "undersea bumps" are meant to be walkable as well as passable for ships (MinWaterDepth = 1, also pathfinder.xml). The random nature of the distribution however makes is a percolation problem that happens to have a far from zero chance of the water beeing passable for some map settings.

So should I reduce the height of the "undersea bumps" to be impassable for units to 2.5? (The cleaner solution would be to check for passability but in RMS there is no access to e.g. the passability code in the engine)

[FeXoR]

This also might have been caused by the hight limit changes, not sure... Edit: No it can't!

[Stan]

Fexor's fix, I tested it on various settings including the ones above, and I cannot reproduce the bug anymore.

[FeXoR]

Due to it's simple nature this patch might be considered to be added for A19.

[mimo]

fixed in r17099, thanks for the patch