Opened 9 years ago
Last modified 3 years ago
#3190 closed task
[PATCH] Update cppformat — at Version 3
| Reported by: | leper | Owned by: | |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Alpha 24 |
| Component: | Core engine | Keywords: | patch |
| Cc: | Patch: |
Description (last modified by )
Currently we use 0.11 while the latest upstream version is 2.1.1 (naming scheme changed, so just 7 versions outdated).
https://github.com/cppformat/cppformat/releases
Also see #3011 for some changes to the bundled version (that should be reapplied or dropped depending on the change (since some where done upstream in a similar/different way)). The remaining changes should be submitted upstream if applicable.
Change History (4)
comment:1 by , 8 years ago
| Description: | modified (diff) |
|---|---|
| Milestone: | Backlog → Alpha 21 |
comment:2 by , 8 years ago
comment:3 by , 8 years ago
| Description: | modified (diff) |
|---|---|
| Keywords: | review added |
| Summary: | Update cppformat → [PATCH] Update cppformat |
Note:
See TracTickets
for help on using tickets.
The attached patches do the following:
cppformat: Update to version 2.1.0 (straight from Github).
cppformatmod: There were some compiler errors related to the isnan function, so I commented it out. This seems to have fixed the errors. It was only a dummy function and shouldn't be used on any sane system anyway.
The patched game compiled flawlessly, passed all tests and "survived" a test game on my system (Linux 4.5.0, GCC 5.3.1). Someone else needs to test this on Windows, OS X, *BSD though.
There are some FMT_THROW calls in there (which I didn't run into) which could be changed to print a warning, similar to patch 0006 from #3011.