Opened 9 years ago
Closed 9 years ago
#3219 closed defect (invalid)
Spatial.h Compiler Warnings
| Reported by: | Josh | Owned by: | Josh |
|---|---|---|---|
| Priority: | Should Have | Milestone: | |
| Component: | Core engine | Keywords: | |
| Cc: | Patch: |
Description
GCC complains about comparisons between the signed SUBDIVISION_SIZE constant and unsigned integers in Spatial.h at the moment.
The attached patch removes the warnings by making SUBDIVISION_SIZE unsigned and casting to signed integers as needed.
Attachments (1)
Change History (4)
by , 9 years ago
| Attachment: | spatial_patch.diff added |
|---|
comment:1 by , 9 years ago
comment:2 by , 9 years ago
It might be better to use u32 instead of uint for consistency with other simulation codes.
comment:3 by , 9 years ago
| Keywords: | review patch removed |
|---|---|
| Milestone: | Alpha 19 |
| Resolution: | → invalid |
| Status: | new → closed |
Hmm, I don't seem to get these warnings on my main machine. I was compiling on the Raspberry Pi and they were getting very annoying, but it must be related to Debian's older version of GCC. If not, I'll re-open this ticket.
Note:
See TracTickets
for help on using tickets.
What are the exact warnings (and/or the version of GCC)?