Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3223 closed defect (fixed)

g_ScriptStatsTable is never deleted in replay mode

Reported by: kanetaka Owned by: leper
Priority: Should Have Milestone: Alpha 19
Component: Core engine Keywords: g_ScriptStatsTable replay
Cc: kanetaka Patch:


CScriptStatsTable* g_ScriptStatsTable is a global pointer. The pointer is deleted in void Shutdown(int flags), GameSetup.cpp, but that function is never called in replay mode.

Attachments (1)

commands2.txt (671 bytes ) - added by kanetaka 8 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by leper, 8 years ago

Owner: set to leper
Resolution: fixed
Status: newclosed

In 16627:

Stop leaking g_ScriptStatsTable in replay mode. Fixes #3223.

by kanetaka, 8 years ago

Attachment: commands2.txt added

comment:2 by kanetaka, 8 years ago

r16627 throws exception in replay mode. Use the attached file for replay. I encountered the issue by Debug build. I will upload the dump file later, but the size is about 200MB and it may take long time.

The dump file

Last edited 8 years ago by kanetaka (previous) (diff)

comment:3 by kanetaka, 8 years ago

Resolution: fixed
Status: closedreopened

comment:4 by leper, 8 years ago

Resolution: fixed
Status: reopenedclosed

In 16631:

Properly fix #3223.

The previous commit destroyed the context while it was still in use.

comment:5 by leper, 8 years ago

Thanks. (Shouldn't change things just before committing.)

Note: See TracTickets for help on using tickets.