#3226 closed defect (fixed)
[PATCH] Wonder Victory message is not shown for observers
Reported by: | elexis | Owned by: | sanderd17 |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 19 |
Component: | UI & Simulation | Keywords: | |
Cc: | Patch: |
Description (last modified by )
When spectating a wonder game, the message "Player X will have won in Y" is not shown for observers after the wonder is built.
This means that observers can't follow the game and miss the climax of the game.
Attachments (2)
Change History (7)
follow-up: 2 comment:1 by , 9 years ago
by , 9 years ago
Attachment: | t3226_wonder_victory_message_for_observers.patch added |
---|
Displays the victory message for observers too.
comment:2 by , 9 years ago
Replying to elexis:
it displays "Player X" (with number X) instead of the actual playername.
The playernames are not saved properly when the game is initialized and there are many places where "Player X" instead of the actual playername is displayed. This issue will be solved in a different ticket soon (see #3253).
comment:3 by , 9 years ago
Component: | Core engine → UI & Simulation |
---|---|
Description: | modified (diff) |
Keywords: | review added |
Milestone: | Backlog → Alpha 19 |
Summary: | Wonder Victory message is not shown for observers → [PATCH] Wonder Victory message is not shown for observers |
by , 9 years ago
Attachment: | t3226_wonder_victory_message_for_observers_v2.patch added |
---|
Added a comment.
comment:5 by , 9 years ago
Keywords: | review removed |
---|
Note:
See TracTickets
for help on using tickets.
Second Issue:
The message is added in WonderVictory.js:
Although it uses cmpPlayer.GetName() it displays "Player X" (with number X) instead of the actual playername.