Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#3226 closed defect (fixed)

[PATCH] Wonder Victory message is not shown for observers

Reported by: elexis Owned by: sanderd17
Priority: Should Have Milestone: Alpha 19
Component: UI & Simulation Keywords:
Cc: Patch:

Description (last modified by elexis)

When spectating a wonder game, the message "Player X will have won in Y" is not shown for observers after the wonder is built.

This means that observers can't follow the game and miss the climax of the game.

Attachments (2)

t3226_wonder_victory_message_for_observers.patch (780 bytes ) - added by elexis 9 years ago.
Displays the victory message for observers too.
t3226_wonder_victory_message_for_observers_v2.patch (1.4 KB ) - added by elexis 9 years ago.
Added a comment.

Download all attachments as: .zip

Change History (7)

comment:1 by elexis, 9 years ago

Second Issue:

The message is added in WonderVictory.js:

	messages.otherMessage = cmpGuiInterface.AddTimeNotification({
		"message": markForTranslation("%(player)s will have won in %(time)s"),
		"players": players,
		"parameters": {"player": cmpPlayer.GetName()},
		"translateMessage": true,
		"translateParameters": [],
	}, time);

Although it uses cmpPlayer.GetName() it displays "Player X" (with number X) instead of the actual playername.

by elexis, 9 years ago

Displays the victory message for observers too.

in reply to:  1 comment:2 by elexis, 9 years ago

Replying to elexis:

it displays "Player X" (with number X) instead of the actual playername.

The playernames are not saved properly when the game is initialized and there are many places where "Player X" instead of the actual playername is displayed. This issue will be solved in a different ticket soon (see #3253).

Last edited 9 years ago by elexis (previous) (diff)

comment:3 by elexis, 9 years ago

Component: Core engineUI & Simulation
Description: modified (diff)
Keywords: review added
Milestone: BacklogAlpha 19
Summary: Wonder Victory message is not shown for observers[PATCH] Wonder Victory message is not shown for observers

by elexis, 9 years ago

Added a comment.

comment:4 by sanderd17, 9 years ago

Owner: set to sanderd17
Resolution: fixed
Status: newclosed

In 16658:

Allow observers to see the wonder victory message. Patch by elexis. Fixes #3226

comment:5 by sanderd17, 9 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.