[PATCH] Population Altering Techs Bug

[Nikos]

When altering the population cost of units with techs, the production queue of structures uses the old value used on the templates instead of the modified one. Units have their correct, modified pop cost though after being trained.

This can lead to cases where you have the population to support a unit, but you can't summon it.

[sanderd17]

Could you add an example technology (perhaps auto researched) to easily test it?

[Nikos]

Replying to sanderd17:

Could you add an example technology (perhaps auto researched) to easily test it?

I believe there's none currently in the main game, but you could use this (edited from my mod to function correctly - using elephant cause it takes more than one pop slots, not sure how a 0.5 pop unit would be handled).

{
    "genericName": "Light Infantry",
    "autoResearch": true,
    "modifications": [
        {"value": "Cost/Population", "replace": 2}
    ],
    "affects": ["Elephant"]
}

*The problem shouldn't be in "multiply" but in the way the game handles it, "replace" had the same issue. *Edit: Changing "multiply": 0.5 to "replace": 2.. cause the elephant has 3 pop.. to avoid possible issues described above.

[Nikos]

I've spotted one more related issue. Adding extra population supply to structures with a tech retains it even if the subject structures are destroyed/deleted.

[Vladislav Belov]

Fix population bonus updates

[sanderd17]

The patch above indeed fixes the population bonus (as mentioned in comment 3) in a correct way (AFAICS).

However, it doesn't fix the population cost issue (the original issue).

[Vladislav Belov]

Replying to sanderd17:

However, it doesn't fix the population cost issue (the original issue).

I think that popcost and popbonus issue need divide in two patches. Or for popbonus need create new issue?

[sanderd17]

Yes, you can create a new issue if you like. However, the changes are small and the pieces of code related, so you can have one combined patch too.

[leper]

cmpTemplateManager since we moved away from the *Man naming scheme quite some time ago. Also inline the QueryInterface call in this case since this is a system component (thus we can assume its existence in js code) and only used once.

[Vladislav Belov]

Replying to leper:

cmpTemplateManager since we moved away from the *Man naming scheme quite some time ago. Also inline the QueryInterface call in this case since this is a system component (thus we can assume its existence in js code) and only used once.

I have changed that, but ProductionQueue contents cmpTemplateMan in other lines, it's need to be replaced?

[leper]

Yes.

Also create patches from the topmost directory (so paths in the diff are like binaries/data/mods/public/simulation/components/ProductionQueue.js instead of ProductionQueue.js (makes it easier to apply)).

[Vladislav Belov]

Fix both issues (cost and bonus)

[Vladislav Belov]

Replying to leper:

Yes.

Also create patches from the topmost directory (so paths in the diff are like binaries/data/mods/public/simulation/components/ProductionQueue.js instead of ProductionQueue.js (makes it easier to apply)).

Ready.

[sanderd17]

Did you test your code?

When testing, I found that the population bonus issue was indeed fixed, but the population cost is not what was described in the original issue. Instead, I saw that the population cost was never applied, apart from the production queue stats. So now, when you train a unit, the production queue reserves the number of slots needed, but uses the unmodified cost again when creating the unit.

[Vladislav Belov]

Replying to sanderd17:

When testing, I found that the population bonus issue was indeed fixed, but the population cost is not what was described in the original issue. Instead, I saw that the population cost was never applied, apart from the production queue stats. So now, when you train a unit, the production queue reserves the number of slots needed, but uses the unmodified cost again when creating the unit.

Entity of unit has creating only after end of production queue. And production queue need modify it. Is it normal (That not entity change itself popcost)?

[sanderd17]

In 16709:

Fix issues with technologies and pop bonus/cost. Patch by Vladislav. Fixes #3236