[PATCH] Don't load trigger scripts twice

[Stan]

When loading gallic fields I get this error

ERROR: JavaScript error: maps/scripts/TriggerHelper.js line 165 Error: SetGlobal "TriggerHelper" called multiple times

---

r16713 fixed the problem above but broke the serialization test mode.

[mimo]

I also have this error, but not on belgian bog (which has no error), but on gallic fields.

[Stan]

Sorry mistook the map

[sanderd17]

It's bacause the new conquest also needs the TriggerHelper functions, and thus the script is loaded twice. Once as part of the victory-scripts, and once as part of the trigger scripts.

Removing it from the trigger scripts list is no option either, since the player can choose the victory type, and f.e. prefer the Wonder or Endless game mode, which doesn't load the TriggerHelper.

Apparently, the TriggerHelper in the conquest scripts is only used to check some classes of entities, which can be done via an extra line of code too.

Another option is to make the list unique in the gamesetup.

[trompetin17]

In 16713:

Fixes #3238, SetGlobal 'TriggerHelper' called multiple times

[Itms]

The fix above breaks the serialization test mode.

For instance, on Greek Acropolis (2), on the second play of the first turn, ConquestStartGameCount (defined in ConquestCommon.js) is called by DoAfterDelay (requested in Conquest.js) but doesn't exist, probably because the script was not reloaded.

Attached patch is a fix proposal, but maybe there is a less hacky way to do that (e.g. by properly checking that the script has been loaded in the good simulation instance).

[Itms]

In 16924:

Fix r16713, refs #3238

[Itms]

In 16925:

Properly check loaded scripts in the second simulation instance of a serialization test. Fixes #3238