Changes between Version 3 and Version 6 of Ticket #3238


Ignore:
Timestamp:
Jun 7, 2015, 4:33:14 PM (9 years ago)
Author:
Itms
Comment:

The fix above breaks the serialization test mode.

For instance, on Greek Acropolis (2), on the second play of the first turn, ConquestStartGameCount (defined in ConquestCommon.js) is called by DoAfterDelay (requested in Conquest.js) but doesn't exist, probably because the script was not reloaded.

Attached patch is a fix proposal, but maybe there is a less hacky way to do that (e.g. by properly checking that the script has been loaded in the good simulation instance).

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3238

    • Property Status newreopened
    • Property Component UI & SimulationCore engine
    • Property Summary Trigger Helper Js Error[PATCH] Don't load trigger scripts twice
    • Property Priority Should HaveNice to Have
    • Property Keywords patch review added
    • Property Milestone BacklogAlpha 19
    • Property Owner set to trompetin17
  • Ticket #3238 – Description

    v3 v6  
    1 When loading gallic fields I get this error
     1~~When loading gallic fields I get this error
    22
    3 ERROR: JavaScript error: maps/scripts/TriggerHelper.js line 165
     3~~ERROR: JavaScript error: maps/scripts/TriggerHelper.js line 165
    44Error: SetGlobal "TriggerHelper" called multiple times
     5
     6--------------
     7
     8r16713 fixed the problem above but broke the serialization test mode.