Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#3257 closed defect (fixed)

Attack notifications for capturing

Reported by: leper Owned by: Vladislav Belov
Priority: Should Have Milestone: Alpha 19
Component: UI & Simulation Keywords: simple patch
Cc: Patch:

Description

Since the introduction of capturing (#996) we do not get attack notifications for buildings that are being captured. (Because they aren't taking damage and cmpArmour (binaries/data/mods/public/simulation/components/Armour.js) is responsible for the attack notification.) The minimap ping is handled via listening to the Attacked message globally and is working.

cmpCapturable should be extended to send attack notifications (by calling into cmpAttackDetection).

Attachments (2)

capturing_alert.patch​ (1.5 KB ) - added by Vladislav Belov 9 years ago.
capturing_alert.2.patch​ (1.6 KB ) - added by Vladislav Belov 9 years ago.

Download all attachments as: .zip

Change History (5)

by Vladislav Belov, 9 years ago

Attachment: capturing_alert.patch​ added

by Vladislav Belov, 9 years ago

Attachment: capturing_alert.2.patch​ added

comment:1 by Vladislav Belov, 9 years ago

Keywords: review patch added
Owner: set to Vladislav Belov
Status: new → assigned

comment:2 by leper, 9 years ago

Resolution: → fixed
Status: assigned → closed

In 16772:

Add attack notifications for capture attacks. Patch by Vladislav. Fixes #3257.

comment:3 by leper, 9 years ago

Keywords: review removed
Milestone: Backlog → Alpha 19

Thanks for the patch.

Note: See TracTickets for help on using tickets.