[PATCH] Clean javascript code syntax of for loops

[elexis]

The attached patch fixes the code style of all for loops and changes all occurances of i++ to ++i (for all variable names). I created the patch the following way:

1. Identify loops with undesired style:

   cd "trunk/binaries/data/mods/public";
   grep -R "++)" --include=*.js  *
   

2. Extract all variable names by hand and save to variables.txt

3. Replace all increments with sed (execute in binaries/data/mods/public)

while read v; do
	find . -name "*.js" -print | xargs sed -i "s/ ${v}++/ ++${v}/g"
done <variables.txt

4. Create a minimalist patch without unified context:

svn diff --diff-cmd diff -x "-U0" http://svn.wildfiregames.com/public/ps/trunk/ > patch

---

leper suggested some sed magic to combine steps 1-3 (not tested):

s/(for[ ]*\([^;];[^;];)([ ]*[^)+])+\+/$1\+\+$2/g

The patch should be ready to commit anyway.

Another thing that might be corrected automatically are those brackets { after for keywords, where a newline should be inserted and not only a space.

[Itms]

I think someone else said it on IRC but this kind of patch is not really good, it's nicer to include style enhancements in other patches.

[leper]

Especially since some of those loops could be changed to other ones if it makes more sense so I'd rather do it when we touch code in that files already instead of doing one big commit that might not fix things in the best way possible.