OOS on rejoin - Petra AI - estimated gather rates

[elexis]

If you start a match with an AI, wait like 30 seconds and rejoin then with a second client, then an OOS will occur. Using attachment:t3255_use_timestamp_and_pid_for_oosdump_filename.patch:ticket:3255​​ you can save oos dumps of both clients and diff them:

--- oos_dump_1432871952_6644.txt	2015-05-29 05:59:13.275462000 +0200
+++ oos_dump_1432871952_6743.txt	2015-05-29 05:59:13.235462000 +0200
@@ -31917,11 +31917,11 @@
         "wood": 8.5,
         "stone": 0,
         "metal": 0
       },
       "currentRates": {
-        "food": 4.592039744164933,
+        "food": 4.5192736462799,
         "wood": 2.9295572765897067,
         "stone": 0,
         "metal": 0
       },
       "lastFailedGather": {},

[elexis]

Two examples containing commands.txt, oos_dumps and diffs. In the first example only a rallypoint was set by player 1. In the second example there was no command issued by player 1.

[mimo]

Rejoin is not yet supported with AI: the serialization of the AI is not 100% deterministic as for example some quantities are recomputed when deserializating while in game, they are computed every n turns for performances. That should be improved in the future, but I don't think this will be done for A19 and it is not a release blocker.

[historic_bruno]

Closing because we need to fix the underlying AI serialization issue, by which point this ticket probably won't be valid anymore.