Opened 9 years ago
Last modified 3 years ago
#3307 closed defect
Translate botnames correctly — at Initial Version
Reported by: | elexis | Owned by: | |
---|---|---|---|
Priority: | If Time Permits | Milestone: | |
Component: | UI – Miscellaneous | Keywords: | |
Cc: | Patch: |
Description
Currently the botnames are translated by the host and broadcasted to the other clients. This means if a chinese player hosts, everyone has chinese botnames.
The correct way to translate botnames would be to save the english name and the roman number in gamesetup.js
to g_GameAttributes
and then translate playernames everywhere in the GUI in case its a bot.
Notice that we can't simply translate in the simulation code, since that would make the gamestates out of sync.
Sometimes the name is accessed by the player assignments, sometimes by the Player component, sometimes by the simulation state. We have to identify all places in the GUI where a playername is used and translate it just in time.
Originally reported in ticket:3253#comment:5.