[PATCH] Population limit is not rounded properly.

[elexis]

Uses Math.floor to fix the number.

[elexis]

Did you change that value with a custom mod or is there a bug in the main game somewhere?

[maveric]

Replying to elexis:

Did you change that value with a custom mod or is there a bug in the main game somewhere?

In the main game.

[Itms]

playerState.popLimit/popMax should be integer, so the rounding must happen in the simulation, not in the GUI.

Also it would be nice to know where this decimal limit comes from, maybe there is a bug somewhere that we don't want to hide by rounding. maveric, do you have steps to reproduce?

[elexis]

Here the structures that gauls can build, affecting population:

structures/gaul_market.xml:    <PopulationBonus>12</PopulationBonus>
structures/gaul_farmstead.xml:		<PopulationBonus>2</PopulationBonus>
structures/gaul_rotarymill.xml:    <PopulationBonus>2</PopulationBonus>
structures/gaul_blacksmith.xml:    <PopulationBonus>4</PopulationBonus>
structures/gaul_fortress.xml:    <PopulationBonus>12</PopulationBonus>
structures/gaul_barracks.xml:    <PopulationBonus>4</PopulationBonus>
structures/gaul_tavern.xml:    <PopulationBonus>10</PopulationBonus>
structures/gaul_storehouse.xml:    <PopulationBonus>2</PopulationBonus>
structures/gaul_temple.xml:    <PopulationBonus>7</PopulationBonus>
structures/gaul_dock.xml:    <PopulationBonus>2</PopulationBonus>

Maybe it was caused by that house upgrade that gives 20% more population capacity. However I could not reproduce the issue.

If you don't know the exact steps, can you find the commands.txt file of that match and upload it? If so, please tell us the revision too (or if it was a18).

[maveric]

I am not sure, but it could happen after capturing enemy buildings.

[elexis]

The scenario map of that replay "The Massacre of Delphi" is interesting for multiple reasons.

The map starts with structures that you can't build with any unit. Gauls have the longhouse and athen has the hellenic special structure (stoa) which can produce champion skirmishers (which you can't produce otherwise).

Replying to Itms:

maybe there is a bug somewhere that we don't want to hide by rounding

The gaul player gets a celtic hut in the south. It gives only +2 pop, and if you use the +20% pop house upgrade, it will upgrade to 2,4 pop count.

Reproduce: (1) Start this map The Massacre of Delphi with cheats (2) Before you lose the hut in the south, type the cheats 2x "back to the future", "bring me my axe 9999" and "i am too busy" (3) Build a house and research the +20% pop tech

You will see that your pop count is now 52.4.

Another bug? If you delete buildings, all following numbers will be messed up - in the end you will even reach a negative number. -If you delete the house you just built, then it goes back to 46.6. -If you delete the longhouse, then the counter goes down to 34.4. -If you delete the CC, you get 14.39999 -If you delete the tavern, you get 2.39999 -Then the last remaining house in the south will become gaia, so that the counter reaches -1.33226715.

[mimo]

In 16848:

rounding needed for houses with popBonus%5 != 0, fixes #3328