construction doesn't start if there is an animal on the construction area

[rogue-spectre]

Hi,

One can order to build a building where some living animals are present but the construction won't start. In the case of chicken they can be hidden in boxes of the construction site and are not easily visible. One must kill them or make them leave in order the construction can start. I think that two behaviours could avoid this :

1 - Don't allow building where there are some animals/people - assuming once the building area is defined, no one can go "inside" the construction site.

2 - "Order" animals to leave a construction site, this could be justified as they will be annoyed by the construction noises.

nice day.

[Itms]

This is strange, 2) should be the current behavior. I'll take a look.

[Itms]

I confirm that everything works here. Which version of the game are you playing on?

[elexis]

Yes, the chicken are actually ordered to move off the foundation. However I also remember experiencing that chicken were stuck on an unbuilt CC. Maybe rogue-spectre or me can reproduce it and upload a commands.txt.

[elexis]

First try. Some chicken flee, others don't.

[rogue-spectre]

last svn 16928. does it. It seems that in fact animals that are "near" the edges of the construction don't get the order to leave more often. If i try to put a construction with a chicken at the center, it will leave.

+ chicken that don't leave don't move around. Their movements are limited to getting food. The more workers are trying to build, the more noise they make.

[elexis]

In the replayfile above, there were also chicken near the center that didn't leave.

[rogue-spectre]

maybe it's a problem of the path finder, since i also noticed that units get stuck easily…

[Itms]

In 16973:

Fix the LeaveFoundation order in UnitAI in the case of animals. The code used was a hack using the fleeing tactics, so use the regular "Order.LeaveFoundation" code shared with non-animal units.

Fixes #3372

[Itms]

This bug was actually not a pathfinder problem, but a UnitAI one. It is fixed now :)

[elexis]

Tested it and can't produce the bug anymore, thx!

[Itms]

In 17013:

Support inverted goals with the long-range pathfinder. This allows units to flee and should fix problems with ranged units too close to their targets. Fixes #3405, refs #3372.

Now that units flee it's necessary to fix the unit chasing: this commit reintroduces some code from r14449 that disappeared with the committing of the new pathfinder. Refs #1537.

Also includes some style improvements to the UnitMotion code.