Violent units follow enemies through the fog of war

[elexis]

According to UnitAI.js:

respondChaseBeyondVision: start chasing, and don't stop even if it's out of this unit's vision range (though still visible to the player)

However the enemy units are also followed if they have reached the fog of war and are invisible to the player. The violent units seem to just follow the path of the enemy (instead of walking the shortest / direct path to the current enemy location).

Reproduce: (1) make men violent (2) Alt+D, enable the change-perspective tool (3) move an enemy cavalry in range of the violent men and run away

Since the cavalry can run faster than the soldiers can walk, the enemy cavalry is soon invisible to the player. You can then move whereever you want to, the violent men will always find you (kinda creepy).

---

A second thing which I'm not sure about:

Aren't violent men supposed to attack all enemies if any of the players units sees that enemy? Currently the violent guys only attack units in vision range.

[elexis]

Sounds similar to #1832

[Imarok]

Move tickets to Simulation as UI & Simulation got some sub components.

[Freagarach]

In 24017:

Do not chase entities in FOW/SOD

Refs #1832 by fixing the non-animal cases.

Differential Revision: D2698
Reviewed by: @bb, @wraitii.
Fixes #3394

[Freagarach]

Replying to elexis:

A second thing which I'm not sure about:

Aren't violent men supposed to attack all enemies if any of the players units sees that enemy? Currently the violent guys only attack units in vision range.

Would be strange to have entities roam across the map to attack first someone here, then someone there.

[Silier]

Still will be present for ai and gaia as they see everything