Units not detecting invalid path.

[Stan]

We played a match today with elexis and ffm, and we noticed that units would often try to go from a point 'a' to a point 'b' without realising they wouldn't be able to reach it. So they just walk into the void.

The only we could workaround it, is by cancelling orders, and removing formations (setting it to none)

FFM stated formation should be disabled whereas I think it should be set to none by default.

[Stan]

The game commands.txt

[elexis]

Replay was done with r17088.

The quickest solution to the formation-question would be #3457 in my opinion. Unfortunately we are already in string freeze and can't add that option for a19.

For the pathfinding issue see also ​http://wildfiregames.com/forum/index.php?showtopic=20073#entry309471

Also notice my cavalry that is stuck at minute 8:30 near the storehouse near the metal/stone at the cc (probably UnitAI not pathfinder in that case).

[elexis]

Initial cavalry (entity ID 259) stuck at turn 1114 (9min 17sec). With regards to getting stuck, the replay still works with r17131. The cavalry gets a gather order at turn 1059 and on turn 1115 this storehouse (entity ID 6392) is placed.

[elexis]

I think this is the same bug as in #3505. We'll see.

[elexis]

Minimum replay for r17144. Contains only one command. Despite #3530, the chicken is killed and gathered from. After that, the cavalry wants to move away (second 3), but is stuck without an obstruction being close enough. Then another chicken moves near the dead one and somehow the cavalry is unstuck (second 15)..

[wraitii]

Attached patch should fix those cases. Needs to be tested. It's, again, not RC yet.

I have also attached a screenshot explaining why I did my clearance changes: there were some cases where the long-range pathfinder saw paths where the short-range didn't. This is now impossible.

Pushing this to release blocker as this patch is a real functional change, and I think it'd also fix #3505 directly.

[wraitii]

Fix the building issue I noticed.

[elexis]

Couldn't reproduce any stuck case with this patch, so it's promising and committing it would definitely improve the situation tremendously. Didn't look at the code though.

[wraitii]

In 17161:

Fix more pathfinding issues.

Change the way the long-range pathfinder rasterisation works slightly so that we have a better compatibility with the short-range pathfinder. Should fix the "stuck units" issues, though I am not sure so I am not marking them as fixed so far. Refs #3471, #3505, and possibly #3292.

Caveat: I am now using clearance of 0.8 for "default" class, which might have side-effects: please report anything weird.

Also fix leftover style issues.

[wraitii]

Testing no longer shows the issue, I believe I have fixed it for the most part. Closing.

[wraitii]

In 17225:

Fix a rare case where units might get stuck around other idle entities, and clarify a related comment.

Refs #3471