[PATCH] Sheeps keep making sounds after death

[Stan]

Some players reported that the sheep continues making sound after dying this is because line 552 of templateLoader.cpp the sound component is transfered to the dead unit.

So here is a one liner that fixes that.

[Stan]

Remove the sound component from dead objects.

[Stan]

Add a comment.

[historic_bruno]

You mean sound when it's selected? I don't think that's a big deal, just like the unit portrait shows a living sheep, the sound is simply a way to identify it.

[Stan]

Implodedok asked me to fix it :) So I submitted a patch :)

[elexis]

To me it makes more sense to disable the sounds of animal corpses. After all it's not the portrait but the unit on the battlefield that emits the sound. So I'd be in favor of fixing it rather than closing it as won't fix.

The patch should fix this for all animal types though (for example chicken and camels too).

[elexis]

In 17399:

Don't emit sounds when selecting dead animals. Patch by Stan. Fixes #3486.

[elexis]

Thanks for the patch

[elexis]

In 17400:

Don't comment out code. Refs #3486.