Opened 4 years ago

Closed 3 years ago

#3512 closed enhancement (fixed)

[PATCH] Send a phase up notification to your teammates

Reported by: stanislas69 Owned by: Bichtiades
Priority: Nice to Have Milestone: Alpha 22
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

Currently only Petra does this. It would be nice that your allies gets notified you phase up, especially since shared vision is now a tech and not automatic.

Attachments (2)

t3512_phaseNotif_WIP_v0.2.patch (7.9 KB) - added by Bichtiades 4 years ago.
t3512_phaseNotif_WIP_v0.3.patch (6.3 KB) - added by Bichtiades 4 years ago.
now the simulation sends a notification with just "player - type - event" fields, and the gui creates the message. I d like to hear suggestions on how to translate the message's string though.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 4 years ago by wraitii

Milestone: BacklogAlpha 20

comment:2 Changed 4 years ago by elexis

Milestone: Alpha 20Backlog

Backlogging due to lack of progress.

comment:3 Changed 4 years ago by Bichtiades

Owner: set to Bichtiades
Status: newassigned

Changed 4 years ago by Bichtiades

Changed 4 years ago by Bichtiades

now the simulation sends a notification with just "player - type - event" fields, and the gui creates the message. I d like to hear suggestions on how to translate the message's string though.

comment:4 Changed 4 years ago by elexis

Keywords: patch added
Milestone: BacklogAlpha 20
Priority: Should HaveNice to Have
Summary: Send a phase up notification to your teammates[PATCH] Send a phase up notification to your teammates
Type: defectenhancement
  • Adding keywords in accordance with wiki:SubmittingPatches.
  • When to receive notificaitons IMO:
    • the player reached age 2 / 3
    • a player researched the wonder maxpop tech
    • the player built, captured or lost a civic center, fortress or wonder (these notifications would also be used in #3743)
    • I'm not convinced it is useful for markets, maybe only for the first market built?
  • Send the notification from OnResearchFinished and OnGlobalOwnershipChanged in Player.js (since the player can cancel the research)
  • Don't use "/allies", since
    • it can't reach observers
    • it means the text will be "Player1: I reached town phase", but it should be "Player1 has reached town phase", just like the defeat-message for example.
    • Instead, add a new type to g_FormatChatMessage which uses a new function formatTeamNotification in messages.js (similar to the other format***Message).
    • You can use g_Players[player].IsMutualAlly[g_ViewedPlayer] or something like that
  • Options:
    • revert options.xml and make this a "general" option (unless you can prove that there will definitely be more options added in the near future)
  • AI notifications:
    • The petra AI sends the same notifications.
    • Hence the duplicate code must be removed from headquarters.js and chatHelper.js (i.e. chatNewPhase and the calls to it and the then unused variables phaseName)
  • Add yourself to the contributor list in your patch, see programming.json (either with or without realname)

comment:5 Changed 4 years ago by Itms

Milestone: Alpha 20Alpha 21

I'm pushing that because the release is getting close :)

comment:6 Changed 4 years ago by Lionkanzen

With a sound can be nice. An additive alert for messages I propose several in a topic.

comment:7 Changed 4 years ago by elexis

Keywords: simple removed

Any updates? (I saw your working copy works again). There are several players who are excited about this feature to be included in alpha 21 and once done, you and your allies will notice the addition to the game in every match. It will shape the strategy discussions in the team chat :)

comment:8 Changed 4 years ago by elexis

Milestone: Alpha 21Backlog

Backlogging due to lack of progress.

comment:9 Changed 3 years ago by elexis

Milestone: BacklogAlpha 22

comment:10 Changed 3 years ago by elexis

Resolution: fixed
Status: assignedclosed

In 19445:

Display a chat notification if an ally has reached a new phase, optionally also if started or aborted.
Remove the equivalent AI chat notifications.

Differential Revision: https://code.wildfiregames.com/D354
Patch By: Polakrity
Fixes #3512

Note: See TracTickets for help on using tickets.