Opened 9 years ago
Closed 7 years ago
#3512 closed enhancement (fixed)
[PATCH] Send a phase up notification to your teammates
Reported by: | Stan | Owned by: | Bichtiades |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 22 |
Component: | UI & Simulation | Keywords: | patch |
Cc: | Patch: |
Description
Currently only Petra does this. It would be nice that your allies gets notified you phase up, especially since shared vision is now a tech and not automatic.
Attachments (2)
Change History (12)
comment:1 by , 8 years ago
Milestone: | Backlog → Alpha 20 |
---|
comment:2 by , 8 years ago
Milestone: | Alpha 20 → Backlog |
---|
comment:3 by , 8 years ago
Owner: | set to |
---|---|
Status: | new → assigned |
by , 8 years ago
Attachment: | t3512_phaseNotif_WIP_v0.2.patch added |
---|
by , 8 years ago
Attachment: | t3512_phaseNotif_WIP_v0.3.patch added |
---|
now the simulation sends a notification with just "player - type - event" fields, and the gui creates the message. I d like to hear suggestions on how to translate the message's string though.
comment:4 by , 8 years ago
Keywords: | patch added |
---|---|
Milestone: | Backlog → Alpha 20 |
Priority: | Should Have → Nice to Have |
Summary: | Send a phase up notification to your teammates → [PATCH] Send a phase up notification to your teammates |
Type: | defect → enhancement |
- Adding keywords in accordance with wiki:SubmittingPatches.
- When to receive notificaitons IMO:
- the player reached age 2 / 3
- a player researched the wonder maxpop tech
- the player built, captured or lost a civic center, fortress or wonder (these notifications would also be used in #3743)
- I'm not convinced it is useful for markets, maybe only for the first market built?
- Send the notification from
OnResearchFinished
andOnGlobalOwnershipChanged
inPlayer.js
(since the player can cancel the research) - Don't use "/allies", since
- it can't reach observers
- it means the text will be "Player1: I reached town phase", but it should be "Player1 has reached town phase", just like the defeat-message for example.
- Instead, add a new type to
g_FormatChatMessage
which uses a new functionformatTeamNotification
inmessages.js
(similar to the otherformat***Message
). - You can use
g_Players[player].IsMutualAlly[g_ViewedPlayer]
or something like that
- Options:
- revert
options.xml
and make this a "general" option (unless you can prove that there will definitely be more options added in the near future)
- revert
- AI notifications:
- The petra AI sends the same notifications.
- Hence the duplicate code must be removed from
headquarters.js
andchatHelper.js
(i.e.chatNewPhase
and the calls to it and the then unused variablesphaseName
)
- Add yourself to the contributor list in your patch, see
programming.json
(either with or without realname)
comment:5 by , 8 years ago
Milestone: | Alpha 20 → Alpha 21 |
---|
I'm pushing that because the release is getting close :)
comment:6 by , 8 years ago
With a sound can be nice. An additive alert for messages I propose several in a topic.
comment:7 by , 8 years ago
Keywords: | simple removed |
---|
Any updates? (I saw your working copy works again). There are several players who are excited about this feature to be included in alpha 21 and once done, you and your allies will notice the addition to the game in every match. It will shape the strategy discussions in the team chat :)
comment:9 by , 7 years ago
Milestone: | Backlog → Alpha 22 |
---|
Patch at https://code.wildfiregames.com/D354
Backlogging due to lack of progress.