[PATCH] Summary screen code style

[bb]

The attached patch improves the code style from the javascript files in /public/gui/summary.

[bb]

Some spaces and let to var changes

[bb]

New version: changed global params into g_GlobalSomething

[elexis]

In 17453:

Summary screen cleanup. Patch by bb, refs #3518.

Renames globals to g_Foo.
Uses let instead of for in loops.
Fixes indentation and some whitespace issues.

[elexis]

Thanks for the patch!

Before the ticket is closed, someone should replace the deprecated for-each with for-in. (For-of probably doesn't work mostly as it loops over objects).

---

Capital letters for constant globals

TLDR: We use g_Foo for GUI code.

Since we had some discussions recently about using CAPS or g_Foo for global consts:

Many JS sites recommend using capitals only for all globals (no matter if const or variable). This is not reflected in our wiki:Coding_Conventions:

global variables should be named with a g_ prefix.

so when following them strictly, they should be renamed to g_Foo or the documentation updated.

By searching for "const" in all "js" files of the gui directory, we can see that most GUI files meanwhile use the g_Foo naming. So it would be more coherent for the summary screen code to use it too. Hence the commit.

[bb]

deprecate the for each to for in and treat "resourcestotal" the same as "unitstotal" and "buildingstotal"

[bb]

splitted from last patch: 2* foreach deprecated

[elexis]

In 17503:

Summary screen cleanup. Based on patch by bb, fixes #3518.

[elexis]

Thanks for the patches.

Notice there was another for-each loop in another file. Also the variable names were wrong as we don't loop over the amount of resources anymore, but over the resource types.