[PATCH] Some obsolete code when compiling with DISABLE_PATHFINDER

[elexis]

In CCmpUnitMotion::BeginPathing, the function GetNearestPointOnGoal would be used if we'd compile with DISABLE_PATHFINDER. But this function does not exist anymore, so it should be either removed or fixed.

The call to the function was introduced in r16751 and that function was removed in the same commit.

[Stan]

Easy fix for it by removing the last reference.

[Stan]

We could also reinclude the function I can make the patch.

[elexis]

By removing I meant removing the functionality (compiling without the pathfinder) as a whole. That flag is only used in this one place, so it wouldn't be a great loss.

If we keep that functionality, it should actually work. I'm not sure if we would need to reintroduce GetNearestPointOnGoal as the new pathfinder probably has the same or similar function under a different name.

[Stan]

Updated Patch → I misunderstood what you meant.

[Itms]

The equivalent function would be the long-range pathfinder's MakeGoalReachable (it can't be used in this situation though). This code is useful for testing purposes only, so I guess using the goal center coordinates would be fine.

[Stan]

Rename it to long pathfinder as the short one isn't affected.

[mimo]

In 17137:

fix a moved function, fixes #3531