Opened 8 years ago
Last modified 8 years ago
#3619 new enhancement
[PATCH] Original soundtrack metadata
Reported by: | elexis | Owned by: | |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Backlog |
Component: | Music & Sound FX | Keywords: | patch |
Cc: | omri | Patch: |
Description
Omri Lahav did a great job on the soundtrack.
We should add some tags to the ogg files, so that the music can be found in the library of regular audio players.
Attachments (2)
Change History (17)
by , 8 years ago
Attachment: | t3619_add_ogg_tags_v1.patch added |
---|
by , 8 years ago
Attachment: | proposed_changes.jpg added |
---|
comment:1 by , 8 years ago
Keywords: | patch review added |
---|---|
Milestone: | Backlog → Alpha 20 |
Summary: | Original soundtrack metadata → [PATCH] Original soundtrack metadata |
comment:2 by , 8 years ago
The tags should be added to original lossless files, not to the compressed vorbis ones, so that when recompressing them they won't vanish: http://trac.wildfiregames.com/browser/audio/trunk/music
comment:3 by , 8 years ago
My friend, elexis, do you use any software that can view and change the information of these sound files?
follow-up: 7 comment:5 by , 8 years ago
As far as I know it is not possible to add metadata to wav files, so the tags would have to be added everytime when the files are compressed again.
This could perhaps be done by writing a script that adds the tags and applying it everytime the files are compressed.
follow-up: 9 comment:6 by , 8 years ago
There are also FLAC files there, iirc they support tags. If the wavs don't support tags we should probably convert them to flac.
comment:7 by , 8 years ago
Replying to elexis:
As far as I know it is not possible to add metadata to wav files, so the tags would have to be added everytime when the files are compressed again.
This could perhaps be done by writing a script that adds the tags and applying it everytime the files are compressed.
My friend, elexis. what is your picture? Could you tell me what software you use to modify these sound files?
comment:9 by , 8 years ago
Keywords: | review removed |
---|
Replying to fabio:
There are also FLAC files there, iirc they support tags. If the wavs don't support tags we should probably convert them to flac.
That's what should be done imo.
comment:12 by , 8 years ago
Cc: | added |
---|---|
Keywords: | review added |
Milestone: | Backlog → Alpha 21 |
Got everything in place, can commit both flac and ogg changes. The latter will most certainly mean everyone has to download 114mb again even when changing only few bytes of those files.
See the screenshot for proposed tags and the patch for the bytes that will change.
comment:14 by , 8 years ago
When regenerating the ogg files it would be nice to use a good vorbis encoder and a consistent bitrate. For some more info see also here: https://wildfiregames.com/forum/index.php?/topic/13859-game-size-and-audio-quality/
comment:15 by , 8 years ago
Keywords: | review removed |
---|
You are right, if those files have to be uploaded/downloaded completely anyway, they should be properly encoded. Will have to do some research and comparisons to find the ideal values.
sanderd17 also noted that a creative commons license hint should be added.
Ugly binary data, but does the job.