Opened 8 years ago
Closed 8 years ago
#3680 closed enhancement (fixed)
Gamesetup cleanup
Reported by: | elexis | Owned by: | |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 20 |
Component: | UI & Simulation | Keywords: | |
Cc: | Patch: |
Change History (5)
comment:1 by , 8 years ago
comment:5 by , 8 years ago
Milestone: | Backlog → Alpha 20 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Summary: | Gamesetup coding conventions → Gamesetup cleanup |
See the last 53 revisions of gamesetup.js (<= r17554).
The code is mostly readable now. Still full of edge-cases and inconsitencies that hide many bugs.
Ideally gamesetup should use the model-view-controller pattern. (One file to update the gamesettings, one file to manage the GUI objects and one file to allow the controller(s) to change the settings from the GUI). This would also solve the persist-match-settings problem.
In order to remove those inconsistencies, it would be good to have one object that holds all GUI object settings, so that all dropdowns and checkboxes work identically (see r17499 in particular).
Note:
See TracTickets
for help on using tickets.
In 17376: