Error in Petra attackPlan.js

[zsolt]

After reopening saved single user match: Gambia River, following Error occurs and slows down the game considerably.

From intresting.log: TypeError: this.queue is undefined

m.AttackPlan.prototype.trainMoreUnits@simulation/ai/petra/attackPlan.js:504:3 m.AttackPlan.prototype.updatePreparation@simulation/ai/petra/attackPlan.js:438:4 m.AttackManager.prototype.update@simulation/ai/petra/attackManager.js:137:8 m.HQ.prototype.update@simulation/ai/petra/headquarters.js:2057:3 m.PetraBot.prototype.OnUpdate@simulation/ai/petra/_petrabot.js:123:3 m.BaseAI.prototype.HandleMessage@simulation/ai/common-api/baseAI.js:81:2</p>

<p class="error">ERROR: JavaScript error: simulation/ai/petra/attackPlan.js line 504 TypeError: this.queue is undefined

[zsolt]

Forgot: It´s on Mac OS X 10.11.2 Game is Version: 0.0.19

[elexis]

Can you also upload the replay (commands.txt)?

If you go to tools & options -> replays, select that game and press delete, it will show you the filepath (make sure not to press yes).

[zsolt]

commands.txt from saved game with error

[zsolt]

Replying to elexis:

Can you also upload the replay (commands.txt)?

If you go to tools & options -> replays, select that game and press delete, it will show you the filepath (make sure not to press yes).

I just did.

[zsolt]

Do you need the saved game too? To reproduce it?

[elexis]

Nah, that should be fine, thank you :)

[mimo]

Replay of saved games are useless for debugging. But if the errors happen just after reopening the game, are you sure it was saved with the same 0ad version ?

[zsolt]

Hi thanks for your quick response. Though I upgraded to the recent version a few days ago I´ve played this match from the beginning with the new version. Till save and reopen it run flawlessly with ok fps and no errors. I can send you additional information if you need/want, like screen shots of the saved games and replay sets. Isn´t there a version stamp in the saved games set? If not, would be probably be a useful feature. Thanks for your effort developing this great game!

[mimo]

And if you open the save game and do nothing (just let the AI play), does the error happen ? if yes, you can upload the saved game here and i'll have a look at it. Otherwise, there is not much we can do without a reproducible way to get this error.

[zsolt]

Replying to mimo:

And if you open the save game and do nothing (just let the AI play), does the error happen ? if yes, you can upload the saved game here and i'll have a look at it. Otherwise, there is not much we can do without a reproducible way to get this error.

Yes, the error just starts right from the beginning. I´ve attached the most recent saved games. Hope thats the right files. Should be at least one of them.

[mimo]

In 17592:

petra: use the proper attack number when deserializing, refs #3720

[mimo]

The savedgame can not be used for understanding the problem, as it is already screwed up. Each petra attack should have its own training queue, which is not present in the savedgame. This should never happen, and we would need the commands.txt of the starting game to understand it. With r17592, if the queue is missing when deserializing, a new one will be created.